R3944Realms/ModernFix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not actually load all models in replaceAll, use clever trick instead

Browse Source 
Otherwise, it takes 20 seconds to run this with just Mekanism+Additions+Pneumaticcraft
This commit is contained in:
embeddedt 2024-01-02 12:17:53 -05:00
parent 3214311bb6
commit 7174ae1454
No known key found for this signature in database
GPG Key ID: A69433EC199B5613
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
forge/src/main/java/org/embeddedt/modernfix/forge/dynresources/ModelBakeEventHelper.java
View File

@ -153,13 +153,26 @@ public class ModelBakeEventHelper {
@Override @Override
public void replaceAll(BiFunction<? super ResourceLocation, ? super BakedModel, ? extends BakedModel> function) { public void replaceAll(BiFunction<? super ResourceLocation, ? super BakedModel, ? extends BakedModel> function) {
ModernFix.LOGGER.warn("Mod '{}' is calling replaceAll on the model registry. This requires temporarily loading every model for that mod, which is slow.", modId); ModernFix.LOGGER.warn("Mod '{}' is calling replaceAll on the model registry. Some hacks will be used to keep this fast, but they may not be 100% compatible.", modId);
List<ResourceLocation> locations = new ArrayList<>(keySet()); List<ResourceLocation> locations = new ArrayList<>(keySet());
for(ResourceLocation location : locations) { for(ResourceLocation location : locations) {
BakedModel existing = get(location); /*
BakedModel replacement = function.apply(location, existing); * Fetching every model is insanely slow. So we call the function with a null object first, since it
if(replacement != existing) { * probably isn't expecting that. If we get an exception thrown, or it returns nonnull, then we know
put(location, replacement); * it actually cares about the given model.
*/
boolean needsReplacement;
try {
needsReplacement = function.apply(location, null) != null;
} catch(Throwable e) {
needsReplacement = true;
}
if(needsReplacement) {
BakedModel existing = get(location);
BakedModel replacement = function.apply(location, existing);
if(replacement != existing) {
put(location, replacement);
}
} }
} }
} }