From 7174ae1454c91ae0ab6917063becd6c23ed221be Mon Sep 17 00:00:00 2001
From: embeddedt <42941056+embeddedt@users.noreply.github.com>
Date: Tue, 2 Jan 2024 12:17:53 -0500
Subject: [PATCH] Do not actually load all models in replaceAll, use clever
 trick instead

Otherwise, it takes 20 seconds to run this with just Mekanism+Additions+Pneumaticcraft
---
 .../dynresources/ModelBakeEventHelper.java    | 23 +++++++++++++++----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/forge/src/main/java/org/embeddedt/modernfix/forge/dynresources/ModelBakeEventHelper.java b/forge/src/main/java/org/embeddedt/modernfix/forge/dynresources/ModelBakeEventHelper.java
index 0aeb9fac..1aa4609f 100644
--- a/forge/src/main/java/org/embeddedt/modernfix/forge/dynresources/ModelBakeEventHelper.java
+++ b/forge/src/main/java/org/embeddedt/modernfix/forge/dynresources/ModelBakeEventHelper.java
@@ -153,13 +153,26 @@ public class ModelBakeEventHelper {
 
             @Override
             public void replaceAll(BiFunction<? super ResourceLocation, ? super BakedModel, ? extends BakedModel> function) {
-                ModernFix.LOGGER.warn("Mod '{}' is calling replaceAll on the model registry. This requires temporarily loading every model for that mod, which is slow.", modId);
+                ModernFix.LOGGER.warn("Mod '{}' is calling replaceAll on the model registry. Some hacks will be used to keep this fast, but they may not be 100% compatible.", modId);
                 List<ResourceLocation> locations = new ArrayList<>(keySet());
                 for(ResourceLocation location : locations) {
-                    BakedModel existing = get(location);
-                    BakedModel replacement = function.apply(location, existing);
-                    if(replacement != existing) {
-                        put(location, replacement);
+                    /*
+                     * Fetching every model is insanely slow. So we call the function with a null object first, since it
+                     * probably isn't expecting that. If we get an exception thrown, or it returns nonnull, then we know
+                     * it actually cares about the given model.
+                     */
+                    boolean needsReplacement;
+                    try {
+                        needsReplacement = function.apply(location, null) != null;
+                    } catch(Throwable e) {
+                        needsReplacement = true;
+                    }
+                    if(needsReplacement) {
+                        BakedModel existing = get(location);
+                        BakedModel replacement = function.apply(location, existing);
+                        if(replacement != existing) {
+                            put(location, replacement);
+                        }
                     }
                 }
             }