From e124f9f881d2ca9fac4145b5565f4b24810f687d Mon Sep 17 00:00:00 2001 From: shiweikang Date: Sat, 11 Apr 2026 12:43:05 +0800 Subject: [PATCH] Proxy: Fix nil pointer panic in BuildStreamURL and resource leak in ParseBody 1. BuildStreamURL: net.ParseIP() returns nil for non-IP hostnames (e.g., "example.com"), then calling nil.To4() panics. Add nil check before calling To4(). 2. ParseBody: defer r.Close() is placed after the ReadAll error check. If ReadAll fails, the function returns early without closing r, causing a resource leak. Move defer to the top of the function. --- internal/utils/utils.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/utils/utils.go b/internal/utils/utils.go index c031c0e59..fe32a4143 100644 --- a/internal/utils/utils.go +++ b/internal/utils/utils.go @@ -69,11 +69,12 @@ func ApiCORS(ctx context.Context, w http.ResponseWriter, r *http.Request) bool { // ParseBody read the body from r, and unmarshal JSON to v. func ParseBody(r io.ReadCloser, v interface{}) error { + defer r.Close() + b, err := io.ReadAll(r) if err != nil { return errors.Wrapf(err, "read body") } - defer r.Close() if len(b) == 0 { return nil @@ -97,7 +98,7 @@ func BuildStreamURL(r string) (string, error) { defaultVhost := !strings.Contains(u.Hostname(), ".") // If hostname is actually an IP address, it's __defaultVhost__. - if ip := net.ParseIP(u.Hostname()); ip.To4() != nil { + if ip := net.ParseIP(u.Hostname()); ip != nil && ip.To4() != nil { defaultVhost = true }