R3944Realms/srs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Proxy: Add UT coverage for nil pointer and resource leak fixes

Browse Source 
Add TestParseBody_CloseCalledOnReadError to verify r.Close() is called
even when ReadAll fails (resource leak fix).

Enhance TestBuildStreamURL with:
- Comment explaining the example.com case would panic before the nil
  pointer fix (net.ParseIP returns nil for non-IP hostnames)
- IPv6 test cases to verify ip.To4() check works correctly
- Clarifying comments for each test case category
This commit is contained in:
Jacob Su 2026-05-19 11:32:14 +08:00
parent e124f9f881
commit df7a5addb8
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
internal/utils/utils_test.go
View File

@ -121,6 +121,19 @@ func TestParseBody_ReadError(t *testing.T) {
}
}
// TestParseBody_CloseCalledOnReadError verifies that r.Close() is called even
// when ReadAll fails - this prevents the resource leak fixed by moving defer
// to the top of the function.
func TestParseBody_CloseCalledOnReadError(t *testing.T) {
rc := &errReadCloser{}
if err := ParseBody(rc, &struct{}{}); err == nil {
t.Fatal("want error")
}
if !rc.closed {
t.Fatal("Close() was not called on read error - resource leak")
}
}
func TestParseBody_UnmarshalError(t *testing.T) {
var v struct{ Name string }
err := ParseBody(io.NopCloser(strings.NewReader("not json")), &v)
@ -136,11 +149,20 @@ func TestBuildStreamURL(t *testing.T) {
cases := []struct {
in, want string
}{
// Domain names with dots use hostname as vhost.
// This case would panic with nil pointer dereference before the fix
// because net.ParseIP("example.com") returns nil and nil.To4() panics.
{"rtmp://example.com/live/stream", "example.com/live/stream"},
{"rtmp://example.com:1935/live/stream", "example.com/live/stream"},
// IPv4 addresses use defaultVhost.
{"rtmp://127.0.0.1/live/stream", "__defaultVhost__/live/stream"},
// Hostnames without dots use defaultVhost.
{"rtmp://localhost/live/stream", "__defaultVhost__/live/stream"},
{"rtmp://localhost:1935/live/stream", "__defaultVhost__/live/stream"},
// IPv6 addresses: net.ParseIP returns non-nil but To4() returns nil,
// but they still get defaultVhost because they contain no dots.
{"rtmp://[::1]/live/stream", "__defaultVhost__/live/stream"},
{"rtmp://[2001:db8::1]:1935/live/stream", "__defaultVhost__/live/stream"},
}
for _, c := range cases {
got, err := BuildStreamURL(c.in)