R3944Realms/PlayerSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "register JDBC driver to work around Forge bug"

Browse Source 
This reverts commit ce0e173a9e.
This commit is contained in:
EoD 2025-05-03 21:16:20 +00:00
parent 606b9e1c1e
commit bcb55c5a67
2 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
build.gradle
View File

@ -151,9 +151,7 @@ dependencies {
// modImplementation project(":myproject") // modImplementation project(":myproject")
// embedd the JDBC driver in the mod using jarJar // embedd the JDBC driver in the mod using jarJar
// JDBC driver auto-detection is broken in Forge as of v47.4.0 runtimeOnly "com.mysql:mysql-connector-j:${jdbc_version}"
// i.e. we need to need it both at compile and runtime
implementation "com.mysql:mysql-connector-j:${jdbc_version}"
jarJar "com.mysql:mysql-connector-j:${jdbc_version}" jarJar "com.mysql:mysql-connector-j:${jdbc_version}"
additionalRuntimeClasspath "com.mysql:mysql-connector-j:${jdbc_version}" additionalRuntimeClasspath "com.mysql:mysql-connector-j:${jdbc_version}"

10
src/main/java/vip/fubuki/playersync/PlayerSync.java
View File

@ -17,11 +17,9 @@ import vip.fubuki.playersync.sync.VanillaSync;
import vip.fubuki.playersync.util.JDBCsetUp; import vip.fubuki.playersync.util.JDBCsetUp;
import java.sql.Connection; import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.ResultSet; import java.sql.ResultSet;
import java.sql.SQLException; import java.sql.SQLException;
import java.sql.Statement; import java.sql.Statement;
import com.mysql.cj.jdbc.Driver;
@Mod(PlayerSync.MODID) @Mod(PlayerSync.MODID)
public class PlayerSync { public class PlayerSync {
@ -36,14 +34,6 @@ public class PlayerSync {
} }
private void commonSetup(final FMLCommonSetupEvent event) { private void commonSetup(final FMLCommonSetupEvent event) {
// JDBC driver auto-detection is broken in Forge as of v47.4.0
// We need to register the driver manually
try {
DriverManager.registerDriver(new Driver());
} catch (SQLException e) {
LOGGER.error("Unable to register JDBC MySQL driver", e);
}
VanillaSync.register(); VanillaSync.register();
event.enqueueWork(() -> { event.enqueueWork(() -> {
// read SYNC_CHAT only within the enqueueWork to reliably get the real // read SYNC_CHAT only within the enqueueWork to reliably get the real