R3944Realms/PlayerSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix advancements disappearing on server transfer

Browse Source 
Minecraft only flushes PlayerAdvancements to disk during auto-save
(~every 5 min). If a player earns an advancement and switches servers
before the next auto-save, store() reads the stale file and the
advancement is lost in the DB.

Fix: call sp.getAdvancements().save() to force flush to disk before
reading the advancement file in store().

Vyrriox
This commit is contained in:
laforetbrut 2026-03-26 17:24:18 +01:00
parent a85131708f
commit 46689a360c
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/vip/fubuki/playersync/sync/VanillaSync.java
View File

@ -835,6 +835,18 @@ public class VanillaSync {
File advancements = null;
byte[] advancementBytes = new byte[0];
if (JdbcConfig.SYNC_ADVANCEMENTS.get()) {
// FIX: Force Minecraft to flush the player's advancements to disk BEFORE reading the file.
// Without this, recently earned advancements may not be in the file yet (Minecraft only
// flushes advancements during auto-save ~every 5 min). If the player switches servers
// before the next auto-save, the stale file is read and new advancements are lost.
if (player instanceof ServerPlayer sp) {
try {
sp.getAdvancements().save();
} catch (Exception e) {
PlayerSync.LOGGER.warn("Failed to flush advancements to disk for player {}", player_uuid, e);
}
}
Path path = player.getServer().getServerDirectory().resolve(getSyncWorldForServer());
File gameDir = path.toFile();
final MinecraftServer server = ServerLifecycleHooks.getCurrentServer();