R3944Realms/ModernFix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change debug thread dump log level from error to info

Browse Source 
Prevents silly people assuming its an error condition. They shouldn't be enabling the debug options in the first place, and they will probably still think its an error because of the scary stack trace they can't understand, but i think making it info log level will be more sensible at least.

I've not made it debug log level but info instead intentionally, since that would cause it to be invisible for most people instead.

An argument against this change would be that info instead of error would make it go to stdout instead of stderr or make it harder to see through other log lines; i can change it to warn log level if desired.

Relevant: https://github.com/decce6/Ixeris/issues/100
This commit is contained in:
Mustafa 2026-04-22 12:40:07 +03:00 committed by GitHub
parent 502857229d
commit ee8825f4a7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/org/embeddedt/modernfix/core/ModernFixMixinPlugin.java
View File

@ -78,8 +78,8 @@ public class ModernFixMixinPlugin implements IMixinConfigPlugin {
while(true) {
try {
Thread.sleep(60000);
logger.error("------ DEBUG THREAD DUMP (occurs every 60 seconds) ------");
logger.error(ThreadDumper.obtainThreadDump());
logger.info("------ DEBUG THREAD DUMP (occurs every 60 seconds) ------");
logger.info(ThreadDumper.obtainThreadDump());
} catch(InterruptedException | RuntimeException e) {}
}
}
@ -300,4 +300,4 @@ public class ModernFixMixinPlugin implements IMixinConfigPlugin {
}
});
}
}
}