diff --git a/common/src/main/java/org/embeddedt/modernfix/util/LayeredForwardingMap.java b/common/src/main/java/org/embeddedt/modernfix/util/LayeredForwardingMap.java new file mode 100644 index 00000000..cf9f3528 --- /dev/null +++ b/common/src/main/java/org/embeddedt/modernfix/util/LayeredForwardingMap.java @@ -0,0 +1,132 @@ +package org.embeddedt.modernfix.util; + +import it.unimi.dsi.fastutil.objects.ObjectOpenHashSet; +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; + +import java.util.*; + +/** + * Simple forwarding map implementation that allows layering multiple maps together. + */ +public class LayeredForwardingMap implements Map { + private final Map[] layers; + + public LayeredForwardingMap(Map[] layers) { + if(layers.length < 1) + throw new IllegalArgumentException(); + for(Map layer : layers) { + if(layer == null) + throw new IllegalArgumentException(); + } + this.layers = layers; + } + + @Override + public int size() { + return 1; + } + + @Override + public boolean isEmpty() { + for(Map map : layers) { + if(!map.isEmpty()) + return false; + } + return true; + } + + @Override + public boolean containsKey(Object key) { + for(Map map : layers) { + if(map.containsKey(key)) + return true; + } + return false; + } + + @Override + public boolean containsValue(Object value) { + for(Map map : layers) { + if(map.containsValue(value)) + return true; + } + return false; + } + + @Override + public V get(Object key) { + for(Map map : layers) { + V value = map.get(key); + if(value != null) + return value; + } + return null; + } + + @Nullable + @Override + public V put(K key, V value) { + if(value == null) + throw new IllegalArgumentException(); + V originalValue = null; + for(Map map : layers) { + V oldVal = map.remove(key); + if(originalValue == null) + originalValue = oldVal; + map.put(key, value); + } + return originalValue; + } + + @Override + public V remove(Object key) { + for(Map map : layers) { + map.remove(key); + } + return null; + } + + @Override + public void putAll(@NotNull Map m) { + for(V value : m.values()) { + if(value == null) + throw new IllegalArgumentException(); + } + for(Map map : layers) { + map.putAll(m); + } + } + + @Override + public void clear() { + throw new UnsupportedOperationException(); + } + + @NotNull + @Override + public Set keySet() { + Set keys = new ObjectOpenHashSet<>(); + for(Map map : layers) { + keys.addAll(map.keySet()); + } + return Collections.unmodifiableSet(keys); + } + + @NotNull + @Override + public Collection values() { + Set keys = keySet(); + List vals = new ArrayList<>(); + for(K key : keys) { + vals.add(get(key)); + } + return vals; + } + + @NotNull + @Override + public Set> entrySet() { + throw new UnsupportedOperationException(); + } +} diff --git a/fabric/src/main/java/org/embeddedt/modernfix/fabric/mixin/perf/dynamic_resources/ModelBakeryMixin.java b/fabric/src/main/java/org/embeddedt/modernfix/fabric/mixin/perf/dynamic_resources/ModelBakeryMixin.java index 3ade5923..0026b064 100644 --- a/fabric/src/main/java/org/embeddedt/modernfix/fabric/mixin/perf/dynamic_resources/ModelBakeryMixin.java +++ b/fabric/src/main/java/org/embeddedt/modernfix/fabric/mixin/perf/dynamic_resources/ModelBakeryMixin.java @@ -8,6 +8,8 @@ import com.google.common.collect.ImmutableList; import com.mojang.math.Transformation; import net.minecraft.client.renderer.block.model.BlockModel; import net.minecraft.client.renderer.block.model.ItemModelGenerator; +import net.minecraft.client.renderer.block.model.MultiVariant; +import net.minecraft.client.renderer.block.model.multipart.MultiPart; import net.minecraft.client.renderer.texture.AtlasSet; import net.minecraft.client.renderer.texture.TextureAtlasSprite; import net.minecraft.client.renderer.texture.TextureManager; @@ -24,6 +26,7 @@ import org.embeddedt.modernfix.annotation.ClientOnlyMixin; import org.embeddedt.modernfix.duck.IExtendedModelBakery; import org.embeddedt.modernfix.dynamicresources.DynamicBakedModelProvider; import org.embeddedt.modernfix.dynamicresources.ModelBakeryHelpers; +import org.embeddedt.modernfix.util.LayeredForwardingMap; import org.jetbrains.annotations.Nullable; import org.slf4j.Logger; import org.spongepowered.asm.mixin.Final; @@ -148,7 +151,7 @@ public abstract class ModelBakeryMixin implements IExtendedModelBakery { this.loadedModels.put(MISSING_MODEL_LOCATION, this.missingModel); this.bakedCache = loadedBakedModels.asMap(); ConcurrentMap unbakedCacheBackingMap = loadedModels.asMap(); - this.unbakedCache = new ForwardingMap() { + Map mutableBackingMap = new ForwardingMap() { @Override protected Map delegate() { return unbakedCacheBackingMap; @@ -160,6 +163,11 @@ public abstract class ModelBakeryMixin implements IExtendedModelBakery { return super.put(key, value); } }; + // discard unwrapped models + int oldSize = this.unbakedCache.size(); + this.unbakedCache.entrySet().removeIf(entry -> entry.getValue() instanceof BlockModel || entry.getValue() instanceof MultiVariant || entry.getValue() instanceof MultiPart); + ModernFix.LOGGER.info("{} models evicted, {} custom models loaded permanently", oldSize - this.unbakedCache.size(), this.unbakedCache.size()); + this.unbakedCache = new LayeredForwardingMap<>(new Map[] { this.unbakedCache, mutableBackingMap }); this.bakedTopLevelModels = new DynamicBakedModelProvider((ModelBakery)(Object)this, bakedCache); // ensure missing model is a permanent override @@ -290,6 +298,10 @@ public abstract class ModelBakeryMixin implements IExtendedModelBakery { } else ibakedmodel = iunbakedmodel.bake((ModelBakery) (Object) this, textureGetter, arg2, arg); } + if(ibakedmodel == null) { + ModernFix.LOGGER.error("Model {} returned null baked model", arg); + ibakedmodel = bakedMissingModel; + } // TODO event this.bakedCache.put(triple, ibakedmodel); cir.setReturnValue(ibakedmodel);