R3944Realms/ModernFix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add framework to load specific mod classes sequentially, preventing deadlocks

Browse Source
This commit is contained in:
embeddedt 2023-06-19 20:57:07 -04:00
parent 5d2310bda4
commit aa3fa93a9f
No known key found for this signature in database
GPG Key ID: A69433EC199B5613
2 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
forge/src/main/java/org/embeddedt/modernfix/forge/classloading/ClassLoadHack.java Normal file
View File

@ -0,0 +1,26 @@
package org.embeddedt.modernfix.forge.classloading;
/**
* Sometimes mods have classes that circularly reference each other. If each of these classes ends up being loaded
* from two mods, a deadlock occurs.
*
* To avoid this problem we maintain a list of classes that should be loaded early and do it via Class.forName.
*/
public class ClassLoadHack {
private static final String[] classesToLoadEarly = new String[] {
"team.creative.creativecore.common.config.ConfigTypeConveration",
"team.creative.creativecore.common.util.ingredient.CreativeIngredient"
};
public static void loadModClasses() {
for(String clzName : classesToLoadEarly) {
try {
Class.forName(clzName);
} catch(Throwable e) {
if(!(e instanceof ClassNotFoundException)) {
e.printStackTrace();
}
}
}
}
}

2
forge/src/main/java/org/embeddedt/modernfix/forge/init/ModernFixForge.java
View File

@ -21,6 +21,7 @@ import net.minecraftforge.fml.server.ServerLifecycleHooks;
import net.minecraftforge.registries.ForgeRegistries; import net.minecraftforge.registries.ForgeRegistries;
import org.apache.commons.lang3.tuple.Pair; import org.apache.commons.lang3.tuple.Pair;
import org.embeddedt.modernfix.ModernFix; import org.embeddedt.modernfix.ModernFix;
import org.embeddedt.modernfix.forge.classloading.ClassLoadHack;
import org.embeddedt.modernfix.forge.classloading.ModFileScanDataDeduplicator; import org.embeddedt.modernfix.forge.classloading.ModFileScanDataDeduplicator;
import org.embeddedt.modernfix.forge.ModernFixConfig; import org.embeddedt.modernfix.forge.ModernFixConfig;
import org.embeddedt.modernfix.entity.EntityDataIDSyncHandler; import org.embeddedt.modernfix.entity.EntityDataIDSyncHandler;
@ -46,6 +47,7 @@ public class ModernFixForge {
MinecraftForge.EVENT_BUS.register(KubeUtil.class); MinecraftForge.EVENT_BUS.register(KubeUtil.class);
PacketHandler.register(); PacketHandler.register();
ModFileScanDataDeduplicator.deduplicate(); ModFileScanDataDeduplicator.deduplicate();
ClassLoadHack.loadModClasses();
} }
@SubscribeEvent @SubscribeEvent