From a70f76a34dae74d033e486775bf4a2fec13219c3 Mon Sep 17 00:00:00 2001 From: embeddedt <42941056+embeddedt@users.noreply.github.com> Date: Fri, 23 Jan 2026 20:20:48 -0500 Subject: [PATCH] Document the reason for lack of optimization --- .../modernfix/forge/load/ModFileScanDataCompactor.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/java/org/embeddedt/modernfix/forge/load/ModFileScanDataCompactor.java b/src/main/java/org/embeddedt/modernfix/forge/load/ModFileScanDataCompactor.java index 7fb217e5..5bb82662 100644 --- a/src/main/java/org/embeddedt/modernfix/forge/load/ModFileScanDataCompactor.java +++ b/src/main/java/org/embeddedt/modernfix/forge/load/ModFileScanDataCompactor.java @@ -66,6 +66,8 @@ public class ModFileScanDataCompactor { a.annotationData().entrySet().stream().collect(Collectors.toUnmodifiableMap(Map.Entry::getKey, e -> { Object annValue = e.getValue(); if (annValue instanceof ArrayList list) { + // We cannot properly compact annValue using List.of() because there are mods that + // (unnecessarily) rely on the list implementation being ArrayList. list.trimToSize(); } return annValue;