From d427c5e05005b9ac1ce5453203fb9d591de44e44 Mon Sep 17 00:00:00 2001
From: embeddedt <42941056+embeddedt@users.noreply.github.com>
Date: Wed, 10 May 2023 18:12:32 -0400
Subject: [PATCH] Invalidate pack caches directly instead of iterating resource
 manager pack list

---
 .../ReloadableResourceManagerMixin.java          | 14 ++------------
 .../resources/PackResourcesCacheEngine.java      | 16 ++++++++++++++++
 .../resourcepacks/ModNioResourcePackMixin.java   |  1 +
 .../resourcepacks/ModFileResourcePackMixin.java  |  1 +
 4 files changed, 20 insertions(+), 12 deletions(-)

diff --git a/common/src/main/java/org/embeddedt/modernfix/common/mixin/perf/resourcepacks/ReloadableResourceManagerMixin.java b/common/src/main/java/org/embeddedt/modernfix/common/mixin/perf/resourcepacks/ReloadableResourceManagerMixin.java
index 9250fcbc..04fb2d8a 100644
--- a/common/src/main/java/org/embeddedt/modernfix/common/mixin/perf/resourcepacks/ReloadableResourceManagerMixin.java
+++ b/common/src/main/java/org/embeddedt/modernfix/common/mixin/perf/resourcepacks/ReloadableResourceManagerMixin.java
@@ -1,28 +1,18 @@
 package org.embeddedt.modernfix.common.mixin.perf.resourcepacks;
 
-import net.minecraft.server.packs.PackResources;
 import net.minecraft.server.packs.resources.SimpleReloadableResourceManager;
 import org.embeddedt.modernfix.ModernFix;
-import org.embeddedt.modernfix.resources.ICachingResourcePack;
-import org.spongepowered.asm.mixin.Final;
+import org.embeddedt.modernfix.resources.PackResourcesCacheEngine;
 import org.spongepowered.asm.mixin.Mixin;
-import org.spongepowered.asm.mixin.Shadow;
 import org.spongepowered.asm.mixin.injection.At;
 import org.spongepowered.asm.mixin.injection.Inject;
 import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
 
-import java.util.List;
-
 @Mixin(SimpleReloadableResourceManager.class)
 public class ReloadableResourceManagerMixin {
-    @Shadow @Final private List<PackResources> packs;
-
     @Inject(method = "createReload", at = @At("HEAD"))
     private void invalidateResourceCaches(CallbackInfoReturnable<?> cir) {
         ModernFix.LOGGER.info("Invalidating pack caches");
-        for(PackResources pack : this.packs) {
-            if(pack instanceof ICachingResourcePack)
-                ((ICachingResourcePack)pack).invalidateCache();
-        }
+        PackResourcesCacheEngine.invalidate();
     }
 }
diff --git a/common/src/main/java/org/embeddedt/modernfix/resources/PackResourcesCacheEngine.java b/common/src/main/java/org/embeddedt/modernfix/resources/PackResourcesCacheEngine.java
index a8333fa3..8c592cdf 100644
--- a/common/src/main/java/org/embeddedt/modernfix/resources/PackResourcesCacheEngine.java
+++ b/common/src/main/java/org/embeddedt/modernfix/resources/PackResourcesCacheEngine.java
@@ -154,4 +154,20 @@ public class PackResourcesCacheEngine {
         }
         return resources;
     }
+
+    private static final WeakHashMap<ICachingResourcePack, Boolean> cachingPacks = new WeakHashMap<>();
+    public static void track(ICachingResourcePack pack) {
+        synchronized (cachingPacks) {
+            cachingPacks.put(pack, Boolean.TRUE);
+        }
+    }
+
+    public static void invalidate() {
+        synchronized (cachingPacks) {
+            cachingPacks.keySet().forEach(pack -> {
+                if(pack != null)
+                    pack.invalidateCache();
+            });
+        }
+    }
 }
diff --git a/fabric/src/main/java/org/embeddedt/modernfix/fabric/mixin/perf/resourcepacks/ModNioResourcePackMixin.java b/fabric/src/main/java/org/embeddedt/modernfix/fabric/mixin/perf/resourcepacks/ModNioResourcePackMixin.java
index c839cdd6..89d0681e 100644
--- a/fabric/src/main/java/org/embeddedt/modernfix/fabric/mixin/perf/resourcepacks/ModNioResourcePackMixin.java
+++ b/fabric/src/main/java/org/embeddedt/modernfix/fabric/mixin/perf/resourcepacks/ModNioResourcePackMixin.java
@@ -29,6 +29,7 @@ public abstract class ModNioResourcePackMixin implements ICachingResourcePack {
     @Inject(method = "<init>", at = @At("RETURN"))
     private void cacheResources(CallbackInfo ci) {
         invalidateCache();
+        PackResourcesCacheEngine.track(this);
     }
 
     @Override
diff --git a/forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/resourcepacks/ModFileResourcePackMixin.java b/forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/resourcepacks/ModFileResourcePackMixin.java
index 8f7bf461..55173bc5 100644
--- a/forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/resourcepacks/ModFileResourcePackMixin.java
+++ b/forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/resourcepacks/ModFileResourcePackMixin.java
@@ -34,6 +34,7 @@ public abstract class ModFileResourcePackMixin implements ICachingResourcePack {
     @Inject(method = "<init>", at = @At("TAIL"))
     private void cacheResources(ModFile modFile, CallbackInfo ci) {
         invalidateCache();
+        PackResourcesCacheEngine.track(this);
     }
 
     @Override