From 9df79d8c8cc23e7a8b98234864a443d21a95d10a Mon Sep 17 00:00:00 2001 From: embeddedt <42941056+embeddedt@users.noreply.github.com> Date: Sat, 21 Sep 2024 14:17:03 -0400 Subject: [PATCH] Skip filtering states when not in a world --- .../perf/dynamic_resources/BlockStateModelLoaderMixin.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/src/main/java/org/embeddedt/modernfix/common/mixin/perf/dynamic_resources/BlockStateModelLoaderMixin.java b/common/src/main/java/org/embeddedt/modernfix/common/mixin/perf/dynamic_resources/BlockStateModelLoaderMixin.java index 673df9dc..a2247c04 100644 --- a/common/src/main/java/org/embeddedt/modernfix/common/mixin/perf/dynamic_resources/BlockStateModelLoaderMixin.java +++ b/common/src/main/java/org/embeddedt/modernfix/common/mixin/perf/dynamic_resources/BlockStateModelLoaderMixin.java @@ -52,8 +52,8 @@ public abstract class BlockStateModelLoaderMixin implements IBlockStateModelLoad var optionalBlock = BuiltInRegistries.BLOCK.getOptional(location.id()); if(optionalBlock.isPresent()) { try { - // Only filter states if we are not in the loading overlay - filteredStates = Minecraft.getInstance().getOverlay() == null ? ModelBakeryHelpers.getBlockStatesForMRL(optionalBlock.get().getStateDefinition(), location) : null; + // Only filter states if we are in a world and not in the loading overlay + filteredStates = (Minecraft.getInstance().getOverlay() == null && Minecraft.getInstance().level != null) ? ModelBakeryHelpers.getBlockStatesForMRL(optionalBlock.get().getStateDefinition(), location) : null; } catch(RuntimeException e) { ModernFix.LOGGER.error("Exception filtering states on {}", location, e); filteredStates = null;