R3944Realms/ModernFix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent crash when server sends invalid palette

Browse Source 
Related: #509
This commit is contained in:
embeddedt 2025-01-20 09:34:51 -05:00
parent e7f86f8687
commit 4a8e0487bc
No known key found for this signature in database
GPG Key ID: A69433EC199B5613
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
common/src/main/java/org/embeddedt/modernfix/common/mixin/perf/compact_bit_storage/PalettedContainerMixin.java
View File

@ -30,8 +30,15 @@ public abstract class PalettedContainerMixin<T> {
} }
} }
if(empty && storArray.length > 0) { if(empty && storArray.length > 0) {
T value;
/* it means the chunk is oversized and wasting memory, take the ID out of the palette and recreate a smaller chunk */ /* it means the chunk is oversized and wasting memory, take the ID out of the palette and recreate a smaller chunk */
T value = this.data.palette().valueFor(0); try {
value = this.data.palette().valueFor(0);
} catch (RuntimeException e) {
// Some mods/servers seem to generate buggy palettes. This is not our fault (the game will likely crash later),
// but we catch it here to avoid receiving bug reports for an issue we didn't cause.
return;
}
this.data = this.createOrReuseData(null, 0); this.data = this.createOrReuseData(null, 0);
this.data.palette().idFor(value); this.data.palette().idFor(value);
} }