From 3dbff477e936d7ffd02067b5c5705527f5c36934 Mon Sep 17 00:00:00 2001
From: embeddedt <42941056+embeddedt@users.noreply.github.com>
Date: Mon, 29 May 2023 18:25:03 -0400
Subject: [PATCH] Improve structure cache wording

---
 .../modernfix/structure/CachingStructureManager.java       | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/common/src/main/java/org/embeddedt/modernfix/structure/CachingStructureManager.java b/common/src/main/java/org/embeddedt/modernfix/structure/CachingStructureManager.java
index 365fb4d7..9f96c0ee 100644
--- a/common/src/main/java/org/embeddedt/modernfix/structure/CachingStructureManager.java
+++ b/common/src/main/java/org/embeddedt/modernfix/structure/CachingStructureManager.java
@@ -62,7 +62,8 @@ public class CachingStructureManager {
             currentTag.putInt("DataVersion", 500);
         }
         int currentDataVersion = currentTag.getInt("DataVersion");
-        if(currentDataVersion < SharedConstants.getCurrentVersion().getWorldVersion()) {
+        int requiredMinimumDataVersion = SharedConstants.getCurrentVersion().getWorldVersion();
+        if(currentDataVersion < requiredMinimumDataVersion) {
             /* Needs upgrade, try looking up from cache */
             MessageDigest hasher = digestThreadLocal.get();
             hasher.reset();
@@ -70,13 +71,13 @@ public class CachingStructureManager {
             CompoundTag cachedUpgraded = getCachedUpgraded(location, truncateHash(hash));
             if(cachedUpgraded == null)
                 cachedUpgraded = getCachedUpgraded(location, hash); /* pick up old cache */
-            if(cachedUpgraded != null && cachedUpgraded.getInt("DataVersion") == SharedConstants.getCurrentVersion().getWorldVersion()) {
+            if(cachedUpgraded != null && cachedUpgraded.getInt("DataVersion") == requiredMinimumDataVersion) {
                 ModernFix.LOGGER.debug("Using cached upgraded version of {}", location);
                 currentTag = cachedUpgraded;
             } else {
                 synchronized (laggyStructureMods) {
                     if(laggyStructureMods.add(location.getNamespace())) {
-                        ModernFix.LOGGER.warn("Mod {} is shipping outdated structure files, which can cause worldgen lag; please report this to them.", location.getNamespace());
+                        ModernFix.LOGGER.warn("The namespace {} contains an outdated structure file, which can cause worldgen lag. Please view debug.log for the full filename, determine which mod provides the structure, and report to the mod/datapack author, including the debug log.", location.getNamespace());
                     }
                 }
                 ModernFix.LOGGER.debug("Structure {} is being run through DFU (hash {}), this will cause launch time delays", location, hash);