From 1cfe0216ac8991ba7b44633579372609e8ffb43c Mon Sep 17 00:00:00 2001 From: embeddedt <42941056+embeddedt@users.noreply.github.com> Date: Thu, 21 Dec 2023 13:31:02 -0500 Subject: [PATCH] Remove CTM layer hacks entirely on 1.19+, code is unused --- .../dynresources/ModernFixCTMPredicate.java | 16 --- .../ctm/CTMPackReloadListenerMixin.java | 109 ------------------ 2 files changed, 125 deletions(-) delete mode 100644 forge/src/main/java/org/embeddedt/modernfix/forge/dynresources/ModernFixCTMPredicate.java delete mode 100644 forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/dynamic_resources/ctm/CTMPackReloadListenerMixin.java diff --git a/forge/src/main/java/org/embeddedt/modernfix/forge/dynresources/ModernFixCTMPredicate.java b/forge/src/main/java/org/embeddedt/modernfix/forge/dynresources/ModernFixCTMPredicate.java deleted file mode 100644 index da75b047..00000000 --- a/forge/src/main/java/org/embeddedt/modernfix/forge/dynresources/ModernFixCTMPredicate.java +++ /dev/null @@ -1,16 +0,0 @@ -package org.embeddedt.modernfix.forge.dynresources; - -import net.minecraft.client.renderer.RenderType; - -import java.util.function.Predicate; - -public class ModernFixCTMPredicate implements Predicate { - public Predicate ctmOverride; - public Predicate defaultPredicate = type -> type == RenderType.solid(); - - @Override - public boolean test(RenderType renderType) { - Predicate override = ctmOverride; - return override != null ? override.test(renderType) : defaultPredicate.test(renderType); - } -} diff --git a/forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/dynamic_resources/ctm/CTMPackReloadListenerMixin.java b/forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/dynamic_resources/ctm/CTMPackReloadListenerMixin.java deleted file mode 100644 index 8c747333..00000000 --- a/forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/dynamic_resources/ctm/CTMPackReloadListenerMixin.java +++ /dev/null @@ -1,109 +0,0 @@ -package org.embeddedt.modernfix.forge.mixin.perf.dynamic_resources.ctm; - -import com.google.common.collect.ImmutableList; -import net.minecraft.client.renderer.ItemBlockRenderTypes; -import net.minecraft.client.renderer.RenderType; -import net.minecraft.client.resources.model.*; -import net.minecraft.core.Holder; -import net.minecraft.resources.ResourceLocation; -import net.minecraft.world.level.block.Block; -import net.minecraft.world.level.block.Blocks; -import net.minecraft.world.level.block.state.BlockState; -import net.minecraftforge.client.ChunkRenderTypeSet; -import net.minecraftforge.registries.ForgeRegistries; -import org.embeddedt.modernfix.ModernFix; -import org.embeddedt.modernfix.ModernFixClient; -import org.embeddedt.modernfix.annotation.ClientOnlyMixin; -import org.embeddedt.modernfix.annotation.RequiresMod; -import org.embeddedt.modernfix.api.entrypoint.ModernFixClientIntegration; -import org.embeddedt.modernfix.api.helpers.ModelHelpers; -import org.spongepowered.asm.mixin.Final; -import org.spongepowered.asm.mixin.Mixin; -import org.spongepowered.asm.mixin.Overwrite; -import org.spongepowered.asm.mixin.Shadow; -import org.spongepowered.asm.mixin.injection.At; -import org.spongepowered.asm.mixin.injection.Inject; -import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; -import team.chisel.ctm.client.model.AbstractCTMBakedModel; -import team.chisel.ctm.client.util.CTMPackReloadListener; - -import java.util.Map; -import java.util.concurrent.ConcurrentHashMap; -import java.util.function.Predicate; - -@Mixin(CTMPackReloadListener.class) -@RequiresMod("ctm_but_dont_actually_enable") -@ClientOnlyMixin -public abstract class CTMPackReloadListenerMixin implements ModernFixClientIntegration { - /* caches the original render checks */ - @Shadow(remap = false) @Final private static Map, Predicate> blockRenderChecks; - - private static Map, Predicate> renderCheckOverrides = new ConcurrentHashMap<>(); - - private static ChunkRenderTypeSet DEFAULT_TYPE_SET = ChunkRenderTypeSet.of(RenderType.solid()); - - @Shadow(remap = false) protected abstract Predicate getLayerCheck(BlockState state, BakedModel model); - - @Shadow(remap = false) protected abstract ChunkRenderTypeSet getExistingRenderCheck(Block block); - - @Inject(method = "", at = @At("RETURN")) - private void onInit(CallbackInfo ci) { - ModernFixClient.CLIENT_INTEGRATIONS.add(this); - } - - /** - * @author embeddedt - * @reason handle layer changes dynamically - */ - @Overwrite(remap = false) - @SuppressWarnings("removal") - private void refreshLayerHacks() { - renderCheckOverrides.clear(); - if(blockRenderChecks.isEmpty()) { - for(Block block : ForgeRegistries.BLOCKS.getValues()) { - Holder.Reference holder = ForgeRegistries.BLOCKS.getDelegateOrThrow(block); - ChunkRenderTypeSet original = this.getExistingRenderCheck(block); - if(original == null) - original = DEFAULT_TYPE_SET; - blockRenderChecks.put(holder, original::contains); - ItemBlockRenderTypes.setRenderLayer(block, type -> this.useOverrideIfPresent(holder, type)); - } - } - } - - private boolean useOverrideIfPresent(Holder.Reference delegate, RenderType type) { - Predicate override = renderCheckOverrides.get(delegate); - if(override == null) - override = blockRenderChecks.get(delegate); - return override.test(type); - } - - @Override - public BakedModel onBakedModelLoad(ResourceLocation location, UnbakedModel baseModel, BakedModel originalModel, ModelState modelState, ModelBakery bakery) { - if(!(location instanceof ModelResourceLocation)) - return originalModel; - if(!(originalModel instanceof AbstractCTMBakedModel || originalModel instanceof WeightedBakedModel || originalModel instanceof MultiPartBakedModel)) - return originalModel; - /* we construct a new ResourceLocation because an MRL is coming in */ - Block block = ForgeRegistries.BLOCKS.getValue(new ResourceLocation(location.getNamespace(), location.getPath())); - Holder.Reference delegate = block != null ? ForgeRegistries.BLOCKS.getDelegateOrThrow(block) : null; - if(block == null || block == Blocks.AIR || renderCheckOverrides.containsKey(delegate)) - return originalModel; - /* find all states that match this MRL */ - ImmutableList allStates; - try { - allStates = ModelHelpers.getBlockStateForLocation(block.getStateDefinition(), (ModelResourceLocation)location); - } catch(RuntimeException e) { - ModernFix.LOGGER.error("Couldn't get state for MRL " + location, e); - return originalModel; - } - for(BlockState state : allStates) { - Predicate newPredicate = this.getLayerCheck(state, originalModel); - if(newPredicate != null) { - renderCheckOverrides.put(delegate, newPredicate); - return originalModel; - } - } - return originalModel; - } -}