R3944Realms/ModernFix-fix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix isOptionEnabled being invoked in hot path during capability provider creation

Browse Source 
Fixes #664
This commit is contained in:
embeddedt 2026-05-15 21:04:40 -04:00
parent 55cec86e5f
commit f931d5c442
No known key found for this signature in database
GPG Key ID: A69433EC199B5613
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/main/java/org/embeddedt/modernfix/forge/capability/analysis/CapabilityAnalyzer.java
View File

@ -34,12 +34,13 @@ public class CapabilityAnalyzer {
private static final String ICAP_PROVIDER_INTERNAL = "net/minecraftforge/common/capabilities/ICapabilityProvider"; private static final String ICAP_PROVIDER_INTERNAL = "net/minecraftforge/common/capabilities/ICapabilityProvider";
public static CapabilityAnalysisResult analyze(Class<? extends ICapabilityProvider> clazz) { public static CapabilityAnalysisResult analyze(Class<? extends ICapabilityProvider> clazz) {
if (!ModernFixMixinPlugin.instance.isOptionEnabled("perf.faster_capabilities.bytecode_analysis.CapabilityAnalyzer")) {
return new CapabilityAnalysisResult.Indeterminate("bytecode analysis disabled");
}
CapabilityAnalysisResult result = cache.get(clazz); CapabilityAnalysisResult result = cache.get(clazz);
if (result != null) return result; if (result != null) return result;
result = doAnalyzeSafe(clazz); if (!ModernFixMixinPlugin.instance.isOptionEnabled("perf.faster_capabilities.bytecode_analysis.CapabilityAnalyzer")) {
result = new CapabilityAnalysisResult.Indeterminate("bytecode analysis disabled");
} else {
result = doAnalyzeSafe(clazz);
}
CapabilityAnalysisResult existing = cache.putIfAbsent(clazz, result); CapabilityAnalysisResult existing = cache.putIfAbsent(clazz, result);
return existing != null ? existing : result; return existing != null ? existing : result;
} }