R3944Realms/ModernFix-fix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Memoize creative tab content building per-tab

Browse Source 
This should greatly reduce lag spikes experienced when opening
the creative inventory with a mod like EMI installed, as the creative
tabs will not be rebuilt a second time
This commit is contained in:
embeddedt 2025-03-06 19:50:43 -05:00
parent 6eb82e1325
commit e2ac3bb97a
No known key found for this signature in database
GPG Key ID: A69433EC199B5613
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
common/src/main/java/org/embeddedt/modernfix/common/mixin/perf/memoize_creative_tab_build/CreativeModeTabMixin.java Normal file
View File

@ -0,0 +1,28 @@
package org.embeddedt.modernfix.common.mixin.perf.memoize_creative_tab_build;
import com.llamalad7.mixinextras.injector.wrapmethod.WrapMethod;
import com.llamalad7.mixinextras.injector.wrapoperation.Operation;
import net.minecraft.world.item.CreativeModeTab;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Unique;
@Mixin(CreativeModeTab.class)
public class CreativeModeTabMixin {
@Unique
private CreativeModeTab.ItemDisplayParameters mfix$oldParameters;
/**
* @author embeddedt
* @reason Vanilla already does similar memoization in the CreativeModeTabs class, but mods often have to bypass
* it due to wanting to build the tab contents before search trees are populated. By memoizing at this lower level,
* we can skip the expensive work of computing the tab contents multiple times while not affecting the logic in
* CreativeModeTabs.
*/
@WrapMethod(method = "buildContents")
private synchronized void buildContentsIfChanged(CreativeModeTab.ItemDisplayParameters parameters, Operation<Void> original) {
if (mfix$oldParameters == null || mfix$oldParameters.needsUpdate(parameters.enabledFeatures(), parameters.hasPermissions(), parameters.holders())) {
original.call(parameters);
}
mfix$oldParameters = parameters;
}
}