R3944Realms/ModernFix-fix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Invalidate pack caches directly instead of iterating resource manager pack list

Browse Source
This commit is contained in:
embeddedt 2023-05-10 18:12:32 -04:00
parent d97da8fe4c
commit d427c5e050
No known key found for this signature in database
GPG Key ID: A69433EC199B5613
4 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
common/src/main/java/org/embeddedt/modernfix/common/mixin/perf/resourcepacks/ReloadableResourceManagerMixin.java
View File

@ -1,28 +1,18 @@
package org.embeddedt.modernfix.common.mixin.perf.resourcepacks;
import net.minecraft.server.packs.PackResources;
import net.minecraft.server.packs.resources.SimpleReloadableResourceManager;
import org.embeddedt.modernfix.ModernFix;
import org.embeddedt.modernfix.resources.ICachingResourcePack;
import org.spongepowered.asm.mixin.Final;
import org.embeddedt.modernfix.resources.PackResourcesCacheEngine;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
import java.util.List;
@Mixin(SimpleReloadableResourceManager.class)
public class ReloadableResourceManagerMixin {
@Shadow @Final private List<PackResources> packs;
@Inject(method = "createReload", at = @At("HEAD"))
private void invalidateResourceCaches(CallbackInfoReturnable<?> cir) {
ModernFix.LOGGER.info("Invalidating pack caches");
for(PackResources pack : this.packs) {
if(pack instanceof ICachingResourcePack)
((ICachingResourcePack)pack).invalidateCache();
}
PackResourcesCacheEngine.invalidate();
}
}

16
common/src/main/java/org/embeddedt/modernfix/resources/PackResourcesCacheEngine.java
View File

@ -154,4 +154,20 @@ public class PackResourcesCacheEngine {
}
return resources;
}
private static final WeakHashMap<ICachingResourcePack, Boolean> cachingPacks = new WeakHashMap<>();
public static void track(ICachingResourcePack pack) {
synchronized (cachingPacks) {
cachingPacks.put(pack, Boolean.TRUE);
}
}
public static void invalidate() {
synchronized (cachingPacks) {
cachingPacks.keySet().forEach(pack -> {
if(pack != null)
pack.invalidateCache();
});
}
}
}

1
fabric/src/main/java/org/embeddedt/modernfix/fabric/mixin/perf/resourcepacks/ModNioResourcePackMixin.java
View File

@ -29,6 +29,7 @@ public abstract class ModNioResourcePackMixin implements ICachingResourcePack {
@Inject(method = "<init>", at = @At("RETURN"))
private void cacheResources(CallbackInfo ci) {
invalidateCache();
PackResourcesCacheEngine.track(this);
}
@Override

1
forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/resourcepacks/ModFileResourcePackMixin.java
View File

@ -34,6 +34,7 @@ public abstract class ModFileResourcePackMixin implements ICachingResourcePack {
@Inject(method = "<init>", at = @At("TAIL"))
private void cacheResources(ModFile modFile, CallbackInfo ci) {
invalidateCache();
PackResourcesCacheEngine.track(this);
}
@Override