From 6b37051980f8d5cb148a975c3f57183fb4e0d38e Mon Sep 17 00:00:00 2001 From: embeddedt <42941056+embeddedt@users.noreply.github.com> Date: Fri, 4 Jul 2025 18:42:39 -0400 Subject: [PATCH] Fix faster_ingredients bypassing defensive copy of ItemValue Kudos to @nutant233 for noticing this --- .../forge/mixin/perf/faster_ingredients/IngredientMixin.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/faster_ingredients/IngredientMixin.java b/forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/faster_ingredients/IngredientMixin.java index e33ca3fd..2840e2f1 100644 --- a/forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/faster_ingredients/IngredientMixin.java +++ b/forge/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/faster_ingredients/IngredientMixin.java @@ -142,9 +142,7 @@ public abstract class IngredientMixin implements ExtendedIngredient { private ItemStack[] computeItemsArray() { // Fast path for case with one item if (this.values.length == 1) { - if (this.values[0] instanceof Ingredient.ItemValue itemValue) { - return new ItemStack[] { itemValue.item }; - } else if (this.values[0] instanceof Ingredient.TagValue tagValue && mfix$areTagsAvailable()) { + if (this.values[0] instanceof Ingredient.TagValue tagValue && mfix$areTagsAvailable()) { var tag = BuiltInRegistries.ITEM.getTag(tagValue.tag); if (tag.isPresent() && tag.get().size() > 0) { var holderSet = tag.get();