修复内容（FML2CRPMResetCompleteDecoder.java）：

对于非 0x02 的数据包：直接释放缓冲区并返回。在重置阶段，唯一需要关注的是 0x02（Login Plugin Response）数据包。其他数据包（如延迟的 PLAY 状态数据包）无法被处于 LOGIN 状态的 MinecraftDecoder 解码，因此安全丢弃。

对于 0x02 + id=98 的数据包：在拦截后添加 buf.release() 来修复内存泄漏。

README.md

@@ -3,8 +3,7 @@
 This is a Velocity plugin that makes it possible to host a modern Forge server behind a Velocity proxy!
 
 Unlike other solutions, this plugin does not require any special modifications to the backend server nor the client. (The player doesn't need to do anything)
-## Only for 1.13-1.20.1
+
-Velocity has now added built-in support for newer mc versions and therefore don't need Ambassador. You might still need PCF mod on the server-side, for more info please visit: https://github.com/adde0109/Proxy-Compatible-Forge
 ## How to get started:
 1. Download and install this plugin to your proxy.
 2. After starting the server, configure the plugin it to your liking using the config file found in the folder "Ambassador".
@@ -14,13 +13,12 @@ Velocity has now added built-in support for newer mc versions and therefore don'
 - https://github.com/caunt/BungeeForge (Legacy forwarding)
 
 ## Features
-* Server switching without any client side mod when the servers are similar. (Mods must match)
+* Server switching using kick to reset the client with configureble message and switch timeout.
-* ServerRedirect support for server switching.
+* ServerRedirect support for auto-reconnecting during switch.
-* Server switching using Client Reset Packet Mod for instant server switching:
+* Server switching using client mod for instant server switching: 
-  
+https://github.com/Just-Chaldea/Forge-Client-Reset-Packet 
-1.16.5: https://github.com/Just-Chaldea/Forge-Client-Reset-Packet
+1.18.2 and 1.19 fork:
-
+https://github.com/adde0109/Forge-Client-Reset-Packet
-1.18.2+: https://www.curseforge.com/minecraft/mc-mods/forge-client-reset-packet-forward
 
 ## Stuck on "Negotiating":
 This is an issue with Client Reset Packet Mod being partly incompatible with certain mods on the client. Please remove incompatible mods on the client if you have this issue. (Yes, this also includes client-side only mods.)

Velocity

@@ -1 +1 @@
-Subproject commit c3583e182ca6585e40d1eef0da8c18547c0b1bc1
+Subproject commit ecf936f35665f9fd0f65ee114062cfbda2b89bf6

build.gradle.kts

@@ -5,7 +5,7 @@ plugins {
 }
 
 group = "org.adde0109"
-version = "1.5.3-beta"
+version = "1.4.5-fix2"
 
 repositories {
     mavenCentral()

src/main/java/org/adde0109/ambassador/Ambassador.java

@@ -18,19 +18,13 @@ import java.util.Map;
 
 import com.velocitypowered.api.proxy.server.RegisteredServer;
 import com.velocitypowered.proxy.VelocityServer;
-import com.velocitypowered.proxy.connection.MinecraftConnection;
-import com.velocitypowered.proxy.connection.client.ConnectedPlayer;
 import com.velocitypowered.proxy.network.ConnectionManager;
-import com.velocitypowered.proxy.protocol.StateRegistry;
-import com.velocitypowered.proxy.protocol.packet.DisconnectPacket;
 import com.velocitypowered.proxy.protocol.packet.brigadier.ArgumentIdentifier;
 import com.velocitypowered.proxy.protocol.packet.brigadier.ArgumentPropertyRegistry;
 import com.velocitypowered.proxy.protocol.packet.brigadier.ArgumentPropertySerializer;
 import io.netty.buffer.ByteBuf;
 import io.netty.channel.Channel;
 import io.netty.channel.ChannelInitializer;
-import net.kyori.adventure.text.Component;
-import net.kyori.adventure.text.minimessage.MiniMessage;
 import org.adde0109.ambassador.velocity.VelocityBackendChannelInitializer;
 import org.adde0109.ambassador.velocity.VelocityServerChannelInitializer;
 import org.adde0109.ambassador.velocity.VelocityEventHandler;
@@ -46,11 +40,11 @@ import java.util.concurrent.TimeUnit;
 import static com.velocitypowered.api.network.ProtocolVersion.MINECRAFT_1_19;
 import static com.velocitypowered.proxy.protocol.packet.brigadier.ArgumentIdentifier.mapSet;
 
-@Plugin(id = "ambassador", name = "Ambassador", version = "1.5.3-beta", authors = {"adde0109"})
+@Plugin(id = "ambassador", name = "Ambassador", version = "1.4.5", authors = {"adde0109"})
 public class Ambassador {
 
   //Don't forget to update checkCompatibleVersion() when changing this value
-  private static final String minVelocityVersion = "velocity-3.3.0-SNAPSHOT-330";
+  private static final String minVelocityVersion = "velocity-3.2.0-SNAPSHOT-330";
 
   public ProxyServer server;
   public final Logger logger;
@@ -81,9 +75,9 @@ public class Ambassador {
     try {
       Class.forName("com.velocitypowered.proxy.protocol.packet.DisconnectPacket");
     } catch (ClassNotFoundException e) {
-        throw new RuntimeException(e);
+      return false;
     }
-      return true;
+    return true;
   }
 
   @Subscribe(order = PostOrder.LAST)
@@ -100,6 +94,7 @@ public class Ambassador {
 
       Path configPath = dataDirectory.resolve("Ambassador.toml");
       config = AmbassadorConfig.read(configPath);
+      config.validate();
 
       inject();
 
@@ -114,6 +109,7 @@ public class Ambassador {
     try {
       Path configPath = dataDirectory.resolve("Ambassador.toml");
       final AmbassadorConfig newconfig = AmbassadorConfig.read(configPath);
+      newconfig.validate();
 
       config = newconfig;
     } catch (Exception e) {
@@ -136,8 +132,8 @@ public class Ambassador {
 
     Method argumentRegistry = ArgumentPropertyRegistry.class.getDeclaredMethod("register", ArgumentIdentifier.class, Class.class, ArgumentPropertySerializer.class);
     argumentRegistry.setAccessible(true);
-    argumentRegistry.invoke(null,ArgumentIdentifier.id("forge:enum", mapSet(MINECRAFT_1_19, 50)), EnumArgumentProperty.class, EnumArgumentPropertySerializer.ENUM);
+    argumentRegistry.invoke(null,ArgumentIdentifier.id("forge:enum", mapSet(MINECRAFT_1_19, -255)), EnumArgumentProperty.class, EnumArgumentPropertySerializer.ENUM);
-    argumentRegistry.invoke(null,ArgumentIdentifier.id("forge:modid", mapSet(MINECRAFT_1_19, 51)), ModIdArgumentProperty.class,
+    argumentRegistry.invoke(null,ArgumentIdentifier.id("forge:modid", mapSet(MINECRAFT_1_19, -254)), ModIdArgumentProperty.class,
             new ArgumentPropertySerializer<>() {
               @Override
               public ModIdArgumentProperty deserialize(ByteBuf buf, ProtocolVersion protocolVersion) {
@@ -156,16 +152,6 @@ public class Ambassador {
     return TEMPORARY_FORCED;
   }
 
-  public void reconnectSwitchPlayer(ConnectedPlayer player) {
-    TEMPORARY_FORCED.put(player.getUsername(), player.getConnectionInFlight().getServer(),
-            config.getServerSwitchCancellationTime(), TimeUnit.SECONDS);
-
-    MiniMessage mm = MiniMessage.miniMessage();
-    Component parsed = mm.deserialize(config.getKickReconnectMessageString());
-
-    player.disconnect(parsed);
-  }
-
   private void initMetrics() {
     Metrics metrics = metricsFactory.make(this, 15655);
   }

src/main/java/org/adde0109/ambassador/AmbassadorConfig.java

@@ -7,126 +7,86 @@ import net.kyori.adventure.text.serializer.gson.GsonComponentSerializer;
 import net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer;
 import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
 
-import java.io.IOException;
 import java.net.URL;
-import java.nio.file.Files;
 import java.nio.file.Path;
 
 public class AmbassadorConfig {
 
-    @Expose
-    private int serverSwitchCancellationTime = 30;
 
-    @Expose
+  @Expose
-    private boolean silenceWarnings = false;
+  private String disconnectResetMessage = "Please reconnect";
-    @Expose
-    private boolean bypassRegistryCheck = false;
-    @Expose
-    private boolean bypassModCheck = false;
 
-    @Expose
+  @Expose
-    private boolean debugMode = false;
+  private int serverSwitchCancellationTime = 120;
 
-    @Expose
+  @Expose
-    private boolean enableKickReset = false;
+  private boolean silenceWarnings = false;
 
-    @Expose
+  private net.kyori.adventure.text.@MonotonicNonNull Component messageAsAsComponent;
-    private String kickReconnectMessageString = "<red>Please reconnect.</red>";
 
-    private AmbassadorConfig(boolean silenceWarnings, boolean bypassRegistryCheck, boolean bypassModCheck,
+  private AmbassadorConfig(String kickResetMessage, int serverSwitchCancellationTime, boolean silenceWarnings) {
-                             boolean debugMode, boolean enableKickReset, String kickReconnectMessageString) {
+    this.disconnectResetMessage = kickResetMessage;
-        this.silenceWarnings = silenceWarnings;
+    this.serverSwitchCancellationTime = serverSwitchCancellationTime;
-        this.bypassRegistryCheck = bypassRegistryCheck;
+    this.silenceWarnings = silenceWarnings;
-        this.bypassModCheck = bypassModCheck;
+  };
-        this.debugMode = debugMode;
+
-        this.enableKickReset = enableKickReset;
+  public void validate() {
-        this.kickReconnectMessageString = kickReconnectMessageString;
+    if (serverSwitchCancellationTime <= 0) {
+      throw new InvalidValueException("'server-switch-cancellation-time' can't be less than nor equal to zero: server-switch-cancellation-time=" + serverSwitchCancellationTime);
+    }
+  }
+
+  public static AmbassadorConfig read(Path path) {
+    URL defaultConfigLocation = AmbassadorConfig.class.getClassLoader()
+            .getResource("default-ambassador.toml");
+    if (defaultConfigLocation == null) {
+      throw new RuntimeException("Default configuration file does not exist.");
     }
 
-    public static AmbassadorConfig read(Path path) throws IOException {
+    CommentedFileConfig config = CommentedFileConfig.builder(path)
-        URL defaultConfigLocation = AmbassadorConfig.class.getClassLoader()
+            .defaultData(defaultConfigLocation)
-                .getResource("default-ambassador.toml");
+            .autosave()
-        if (defaultConfigLocation == null) {
+            .preserveInsertionOrder()
-            throw new RuntimeException("Default configuration file does not exist.");
+            .sync()
-        }
+            .build();
+    config.load();
 
-        CommentedFileConfig config = CommentedFileConfig.builder(path)
+    double configVersion;
-                .defaultData(defaultConfigLocation)
+    try {
-                .autosave()
+      configVersion = Double.parseDouble(config.getOrElse("config-version", "1.0"));
-                .preserveInsertionOrder()
+    } catch (NumberFormatException e) {
-                .sync()
+      configVersion = 1.0;
-                .build();
-        config.load();
-
-        double configVersion;
-        try {
-            configVersion = Double.parseDouble(config.getOrElse("config-version", "1.0"));
-        } catch (NumberFormatException e) {
-            configVersion = 1.0;
-        }
-
-        boolean silenceWarnings = config.getOrElse("silence-warnings", false);
-
-        int serverSwitchCancellationTime = config.getOrElse("serverRedirectTimeout", 30);
-
-        boolean bypassRegistryCheck = config.getOrElse("bypass-registry-checks", false);
-
-        boolean bypassModCheck = config.getOrElse("bypass-mod-checks", false);
-
-        boolean debugMode = config.getOrElse("debug-mode", false);
-
-        String kickReconnectMessageString = config.getOrElse("disconnect-reset-message",
-                config.getOrElse("reconnect-message", "<red>Please reconnect.</red>"));
-
-        //Upgrade config
-        if (configVersion <= 2.0) {
-            Files.delete(path);
-            config = CommentedFileConfig.builder(path)
-                    .defaultData(defaultConfigLocation)
-                    .autosave()
-                    .preserveInsertionOrder()
-                    .sync()
-                    .build();
-            config.load();
-            config.set("silence-warnings", silenceWarnings);
-            config.set("serverRedirectTimeout", serverSwitchCancellationTime);
-            config.set("bypass-registry-checks", bypassRegistryCheck);
-            config.set("bypass-mod-checks", bypassModCheck);
-            config.set("debug-mode", debugMode);
-            config.set("reconnect-message", kickReconnectMessageString);
-        }
-
-        boolean enableKickReset = config.getOrElse("enable-kick-reset", false);
-
-        return new AmbassadorConfig(silenceWarnings, bypassRegistryCheck, bypassModCheck,
-                debugMode, enableKickReset, kickReconnectMessageString);
     }
 
-    public int getServerSwitchCancellationTime() {
+    if (configVersion < 1.1) {
-        return serverSwitchCancellationTime;
+      config.set("silence-warnings", false);
+      config.set("config-version", "1.2");
     }
 
-    public boolean isSilenceWarnings() {
+    String kickResetMessage = config.getOrElse("disconnect-reset-message", "Please reconnect");
-        return silenceWarnings;
+    int serverSwitchCancellationTime = config.getIntOrElse("server-switch-cancellation-time", 120);
-    }
 
-    public boolean isBypassRegistryCheck() {
+    boolean silenceWarnings = config.getOrElse("silence-warnings", false);
-        return bypassRegistryCheck;
-    }
 
-    public boolean isBypassModCheck() {
+    return new AmbassadorConfig(kickResetMessage, serverSwitchCancellationTime, silenceWarnings);
-        return bypassModCheck;
+  }
-    }
 
-    public boolean isDebugMode() {
+  public net.kyori.adventure.text.Component getDisconnectResetMessage() {
-        return debugMode;
+    if (messageAsAsComponent == null) {
+      if (disconnectResetMessage.startsWith("{")) {
+        messageAsAsComponent = GsonComponentSerializer.gson().deserialize(disconnectResetMessage);
+      } else {
+        messageAsAsComponent = LegacyComponentSerializer.legacyAmpersand().deserialize(disconnectResetMessage);
+      }
     }
+    return messageAsAsComponent;
+  }
 
-    public boolean isEnableKickReset() {
+  public int getServerSwitchCancellationTime() {
-        return enableKickReset;
+    return serverSwitchCancellationTime;
-    }
+  }
 
-    public String getKickReconnectMessageString() {
+  public boolean isSilenceWarnings() {
-        return kickReconnectMessageString;
+    return silenceWarnings;
-    }
+  }
 }

src/main/java/org/adde0109/ambassador/forge/ForgeHandshake.java

@@ -1,42 +0,0 @@
-package org.adde0109.ambassador.forge;
-
-import org.adde0109.ambassador.forge.packet.Context;
-import org.adde0109.ambassador.forge.packet.GenericForgeLoginWrapperPacket;
-import org.adde0109.ambassador.forge.packet.ModListReplyPacket;
-import org.adde0109.ambassador.forge.packet.RegistryPacket;
-
-import java.util.HashMap;
-import java.util.Map;
-import java.util.zip.Adler32;
-import java.util.zip.Checksum;
-
-public class ForgeHandshake {
-    private ModListReplyPacket modListReplyPacket;
-    private final Map<String, Long> registries = new HashMap<>();
-    public GenericForgeLoginWrapperPacket<Context.ClientContext> zetaFlagsPacket;
-
-    public ForgeHandshake() {
-    }
-
-    public ModListReplyPacket getModListReplyPacket() {
-        return modListReplyPacket;
-    }
-
-    public void setModListReplyPacket(ModListReplyPacket modListReplyPacket) {
-        this.modListReplyPacket = modListReplyPacket;
-    }
-
-    public void addRegistry(RegistryPacket packet) {
-        Checksum registryChecksum = new Adler32();
-        registryChecksum.update(packet.getSnapshot());
-        registries.put(packet.getRegistryName(), registryChecksum.getValue());
-    }
-
-    public Map<String, Long> getRegistries() {
-        return registries;
-    }
-
-    public boolean isCompatible(ForgeHandshake handshake) {
-        return this.registries.equals(handshake.registries);
-    }
-}

src/main/java/org/adde0109/ambassador/forge/ForgeHandshakeUtils.java

@@ -3,12 +3,6 @@ package org.adde0109.ambassador.forge;
 import com.google.common.io.ByteArrayDataInput;
 import com.google.common.io.ByteArrayDataOutput;
 import com.google.common.io.ByteStreams;
-import com.velocitypowered.proxy.protocol.ProtocolUtils;
-import io.netty.buffer.ByteBuf;
-import io.netty.buffer.Unpooled;
-import org.adde0109.ambassador.forge.packet.Context;
-import org.adde0109.ambassador.forge.packet.GenericForgeLoginWrapperPacket;
-import org.adde0109.ambassador.forge.packet.IForgeLoginWrapperPacket;
 
 import java.nio.charset.StandardCharsets;
 
@@ -116,61 +110,4 @@ public class ForgeHandshakeUtils {
     stream.write(dataAndPacketId);
     return stream.toByteArray();
   }
-
-  public static class ThirdPartyRegistryUtils {
-
-    static enum ThirdPartyChannel {
-      SILENTGEAR_NETWORK {
-        @Override
-        public IForgeLoginWrapperPacket<Context.ClientContext> generateResponsePacket(Context.ClientContext context, ForgeHandshake completed) {
-          return new ACKPacket(context, 3);
-        }
-      },
-      ZETA_MAIN {
-        @Override
-        public IForgeLoginWrapperPacket<Context.ClientContext> generateResponsePacket(Context.ClientContext context, ForgeHandshake completed) {
-          return new GenericForgeLoginWrapperPacket<Context.ClientContext>(completed.zetaFlagsPacket.getContent(), context);
-        }
-      };
-      abstract public IForgeLoginWrapperPacket<Context.ClientContext> generateResponsePacket(Context.ClientContext context, ForgeHandshake completed);
-    }
-
-    static boolean isThirdPartyPacket(GenericForgeLoginWrapperPacket<Context> packet) {
-      try {
-        Enum.valueOf(ThirdPartyChannel.class,
-                packet.getContext().getChannelName().replace(':', '_').toUpperCase());
-        return true;
-      } catch (IllegalArgumentException e) {
-        return false;
-      }
-    }
-
-    static ThirdPartyChannel getThirdPartyChannel(GenericForgeLoginWrapperPacket<Context> packet) {
-      return Enum.valueOf(ThirdPartyChannel.class,
-              packet.getContext().getChannelName().replace(':', '_').toUpperCase());
-    }
-
-    static class ACKPacket implements IForgeLoginWrapperPacket<Context.ClientContext> {
-
-      private final Context.ClientContext context;
-      private final int packetID;
-      ACKPacket(Context.ClientContext context, int packetID) {
-        this.context = context;
-        this.packetID = packetID;
-      }
-
-      public ByteBuf encode() {
-        ByteBuf buf = Unpooled.buffer();
-
-        ProtocolUtils.writeVarInt(buf, packetID);
-
-        return buf;
-      }
-
-      @Override
-      public Context.ClientContext getContext() {
-        return context;
-      }
-    }
-  }
 }

src/main/java/org/adde0109/ambassador/forge/ShadowHandshakeReceiver.java

@@ -1,70 +0,0 @@
-package org.adde0109.ambassador.forge;
-
-import com.velocitypowered.proxy.connection.client.ConnectedPlayer;
-import org.adde0109.ambassador.forge.packet.*;
-
-import java.util.HashMap;
-import java.util.Map;
-import java.util.zip.Adler32;
-import java.util.zip.Checksum;
-
-public class ShadowHandshakeReceiver {
-
-  private final ConnectedPlayer player;
-  private final ModListReplyPacket modListReplyPacket;
-  private final Map<String, Long> registries;
-
-  private ShadowHandshakeReceiver(ConnectedPlayer player, ModListReplyPacket modListReplyPacket,
-                                 Map<String, Long> registries) {
-    this.player = player;
-    this.modListReplyPacket = modListReplyPacket;
-    this.registries = registries;
-  }
-
-  void handle(IForgeLoginWrapperPacket packet) throws IncompatibleHandshake {
-
-  }
-
-  void handle(ModListPacket packet) throws IncompatibleHandshake {
-
-    //player.getConnection().write();
-  }
-
-  void handle(RegistryPacket packet) throws IncompatibleHandshake {
-
-    player.getConnection().write(new ACKPacket(Context.fromContext(packet.getContext(), true)));
-  }
-  void handle(ConfigDataPacket packet) throws IncompatibleHandshake {
-
-    player.getConnection().write(new ACKPacket(Context.fromContext(packet.getContext(), true)));
-  }
-
-  static class Builder {
-
-    ConnectedPlayer player;
-    ModListReplyPacket modListReplyPacket;
-    Map<String, Long> registries = new HashMap<>();
-
-    void addModListPacket(ModListPacket packet) {
-
-    }
-    void setModListReplyPacket(ModListReplyPacket packet) {
-      this.modListReplyPacket = packet;
-    }
-
-    void addRegistryPacket(RegistryPacket packet) {
-      Checksum registryChecksum = new Adler32();
-      registryChecksum.update(packet.getSnapshot());
-      registries.put(packet.getRegistryName(), registryChecksum.getValue());
-    }
-
-    ShadowHandshakeReceiver build() {
-      return new ShadowHandshakeReceiver(player, modListReplyPacket, registries);
-    }
-  }
-
-
-  class IncompatibleHandshake extends Throwable {
-
-  }
-}

src/main/java/org/adde0109/ambassador/forge/VelocityForgeBackendConnectionPhase.java

@@ -6,21 +6,19 @@ import com.velocitypowered.proxy.connection.backend.VelocityServerConnection;
 import com.velocitypowered.proxy.connection.client.ConnectedPlayer;
 import com.velocitypowered.proxy.network.Connections;
 import com.velocitypowered.proxy.protocol.ProtocolUtils;
+import com.velocitypowered.proxy.protocol.StateRegistry;
 import com.velocitypowered.proxy.protocol.packet.AvailableCommandsPacket;
+import com.velocitypowered.proxy.protocol.packet.LoginPluginMessagePacket;
 import com.velocitypowered.proxy.protocol.packet.PluginMessagePacket;
-import net.kyori.adventure.text.Component;
+import io.netty.buffer.ByteBuf;
-import org.adde0109.ambassador.Ambassador;
-import org.adde0109.ambassador.forge.packet.*;
 import org.adde0109.ambassador.forge.pipeline.CommandDecoderErrorCatcher;
-
+import org.adde0109.ambassador.forge.pipeline.ForgeLoginWrapperDecoder;
-import java.util.concurrent.CompletableFuture;
-import java.util.concurrent.CountDownLatch;
 
 public enum VelocityForgeBackendConnectionPhase implements BackendConnectionPhase {
-  NOT_STARTED {
+  NOT_STARTED() {
     @Override
     VelocityForgeBackendConnectionPhase nextPhase() {
-      return IN_PROGRESS;
+      return WAITING_FOR_ACK;
     }
 
     @Override
@@ -29,7 +27,7 @@ public enum VelocityForgeBackendConnectionPhase implements BackendConnectionPhas
       return true;
     }
   },
-  IN_PROGRESS {
+  WAITING_FOR_ACK() {
     @Override
     public void onLoginSuccess(VelocityServerConnection serverCon, ConnectedPlayer player) {
       serverCon.setConnectionPhase(VelocityForgeBackendConnectionPhase.COMPLETE);
@@ -49,119 +47,43 @@ public enum VelocityForgeBackendConnectionPhase implements BackendConnectionPhas
     }
   },
 
-  COMPLETE {
+  COMPLETE() {
     @Override
     public boolean consideredComplete() {
       return true;
     }
   };
 
-  public ForgeHandshake handshake = new ForgeHandshake();
+
-  CountDownLatch remainingRegistries;
 
   VelocityForgeBackendConnectionPhase() {
   }
 
-  public void handle(VelocityServerConnection server, ConnectedPlayer player, IForgeLoginWrapperPacket<Context> message) {
+  public void handle(VelocityServerConnection server, ConnectedPlayer player, LoginPluginMessagePacket message) {
+
     VelocityForgeBackendConnectionPhase newPhase = getNewPhase(server,message);
 
     server.setConnectionPhase(newPhase);
 
-    //Forge -> Forge
+    //Reset client if not ready to receive new handshake
-
     VelocityForgeClientConnectionPhase clientPhase = (VelocityForgeClientConnectionPhase) player.getPhase();
-
+    if (clientPhase != VelocityForgeClientConnectionPhase.NOT_STARTED) {
-
+      clientPhase.resetConnectionPhase(player);
-    if (!player.isActive()) {
+      if (clientPhase == VelocityForgeClientConnectionPhase.COMPLETE)
-      return;
+      {
-    }
+        //Do not continue if the client can't reset.
-
-    if (!clientPhase.consideredComplete()) {
-      //Initial Forge
-      if (message instanceof ModListPacket modListPacket) {
-        clientPhase.forgeHandshake = new ForgeHandshake();
-      }
-      if (message instanceof RegistryPacket registryPacket) {
-        clientPhase.forgeHandshake.addRegistry(registryPacket);
-      }
-      player.getConnection().write(message);
-    } else {
-      //Reset client if not ready to receive new handshake
-      if (clientPhase.getResetType() == VelocityForgeClientConnectionPhase.ClientResetType.CRP ||
-              clientPhase.getResetType() == VelocityForgeClientConnectionPhase.ClientResetType.SR) {
-        clientPhase.resetConnectionPhase(player);
-        player.getConnection().write(message);
         return;
       }
-
-      if (clientPhase.forgeHandshake.getModListReplyPacket() == null) {
-        //We have nothing to respond with during this handshake. Unable to proceed.
-        if (Ambassador.getInstance().config.isEnableKickReset()) {
-          //Kick-reset
-          Ambassador.getInstance().reconnectSwitchPlayer(player);
-        } else {
-          Ambassador.getInstance().logger.error("Unable for {} to switch servers. Vanilla({}) -> Forge({}) switch " +
-                          "without client side mod or kick-reset enabled is not yet supported!",
-                  player.getGameProfile().getName(), player.getConnectedServer().getServerInfo().getName(),
-                  server.getServerInfo().getName());
-          server.disconnect();
-        }
-        return;
-      }
-
-      if (message instanceof ModListPacket modListPacket) {
-        remainingRegistries = new CountDownLatch(modListPacket.getRegistries().size());
-
-        if (Ambassador.getInstance().config.isDebugMode())
-          player.sendMessage(Component.text("Expecting " + modListPacket.getRegistries().size() +
-                  " packets from server " + server.getServer().getServerInfo().getName()));
-
-        long time = System.currentTimeMillis();
-        CompletableFuture.runAsync(() -> {
-          try {
-            remainingRegistries.await();
-          } catch (InterruptedException e) {
-            throw new RuntimeException(e);
-          }
-        }).thenAcceptAsync((v) -> {
-
-          if(Ambassador.getInstance().config.isDebugMode()) {
-            player.sendMessage(Component.text("Handshake took: " + (System.currentTimeMillis()-time) + " ms"));
-            player.sendMessage(Component.text("Avg packet time" +
-                    (System.currentTimeMillis()-time)/modListPacket.getRegistries().size() + " ms"));
-          }
-
-          if (Ambassador.getInstance().config.isBypassRegistryCheck() ||
-                  clientPhase.forgeHandshake.isCompatible(handshake)) {
-            server.ensureConnected().write(clientPhase.forgeHandshake.getModListReplyPacket());
-          } else if (Ambassador.getInstance().config.isEnableKickReset()) {
-            //Kick-reset
-            Ambassador.getInstance().reconnectSwitchPlayer(player);
-          } else {
-            Ambassador.getInstance().logger.error("Unable to switch due to the registries of " +
-                    server.getServer().getServerInfo().getName() + " being different from the registries of " +
-                    player.getConnectedServer().getServer().getServerInfo().getName());
-            server.disconnect();
-          }
-        }, server.ensureConnected().eventLoop());
-      } else if (message instanceof RegistryPacket registryPacket) {
-        server.getConnection().write(new ACKPacket(Context.fromContext(message.getContext(), true)));
-        handshake.addRegistry(registryPacket);
-        remainingRegistries.countDown();
-      } else if (message instanceof ConfigDataPacket) {
-        server.getConnection().write(new ACKPacket(Context.fromContext(message.getContext(), true)));
-      } else if (message instanceof GenericForgeLoginWrapperPacket<Context> packet
-              && ForgeHandshakeUtils.ThirdPartyRegistryUtils.isThirdPartyPacket(packet)) {
-          server.getConnection().write(
-                  ForgeHandshakeUtils.ThirdPartyRegistryUtils.getThirdPartyChannel(packet).
-                          generateResponsePacket(
-                                  Context.ClientContext.fromContext(packet.getContext(), true),
-                                  clientPhase.forgeHandshake));
-      }
     }
+    message.retain();
+    player.getConnection().write(message);
     //Forge server
     //To avoid unnecessary resets, we wait until we get the handshake even if we know that we should
     //reset because that the previous server was Forge.
+
+    ForgeLoginWrapperDecoder decoder = (ForgeLoginWrapperDecoder) player.getConnection()
+            .getChannel().pipeline().get(ForgeConstants.FORGE_HANDSHAKE_DECODER);
+    decoder.registerLoginWrapperID(message.getId());
   }
 
   public void onLoginSuccess(VelocityServerConnection serverCon, ConnectedPlayer player) {
@@ -175,7 +97,7 @@ public enum VelocityForgeBackendConnectionPhase implements BackendConnectionPhas
   }
 
   private VelocityForgeBackendConnectionPhase getNewPhase(VelocityServerConnection serverConnection,
-                                                       IForgeLoginWrapperPacket<Context> packet) {
+                                                       LoginPluginMessagePacket packet) {
     VelocityForgeBackendConnectionPhase phaseToTransitionTo = nextPhase();
     if (phaseToTransitionTo != this) {
       phaseToTransitionTo.onTransitionToNewPhase(serverConnection);

src/main/java/org/adde0109/ambassador/forge/VelocityForgeClientConnectionPhase.java

@@ -16,10 +16,9 @@ import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import net.kyori.adventure.text.Component;
 import org.adde0109.ambassador.Ambassador;
-import org.adde0109.ambassador.forge.packet.Context;
-import org.adde0109.ambassador.forge.packet.GenericForgeLoginWrapperPacket;
 import org.adde0109.ambassador.forge.packet.IForgeLoginWrapperPacket;
 import org.adde0109.ambassador.forge.packet.ModListReplyPacket;
+import org.adde0109.ambassador.forge.pipeline.ForgeLoginWrapperDecoder;
 import org.adde0109.ambassador.velocity.client.FML2CRPMResetCompleteDecoder;
 import org.adde0109.ambassador.velocity.client.OutboundSuccessHolder;
 import org.adde0109.ambassador.velocity.client.ClientPacketQueue;
@@ -36,15 +35,54 @@ public enum VelocityForgeClientConnectionPhase implements ClientConnectionPhase
     }
 
     @Override
-    public void complete(ConnectedPlayer player) {
+    public void resetConnectionPhase(ConnectedPlayer player) {
-      //When no handshake has taken place.
+      RESETTABLE.resetConnectionPhase(player);
-      //Test if the client supports CRP.
-      ClientResetType.CRP.doReset(player);
     }
-    },
+  },
   IN_PROGRESS {
   },
-  WAITING_RESET() {
+  RESETTABLE {
+    @Override
+    void onTransitionToNewPhase(ConnectedPlayer player) {
+      //Plugins may now send packets to client
+      player.getConnection().getChannel().pipeline().remove(ForgeConstants.PLUGIN_PACKET_QUEUE);
+      ((VelocityServer) Ambassador.getInstance().server).registerConnection(player);
+    }
+
+    @Override
+    public void resetConnectionPhase(ConnectedPlayer player) {
+      MinecraftConnection connection = player.getConnection();
+
+      //There is no going back even if the handshake fails. No reason to still be connected.
+      if (player.getConnectedServer() != null) {
+        player.getConnectedServer().disconnect();
+        player.setConnectedServer(null);
+      }
+      //Don't handle anything from the server until the reset has completed.
+      //player.getConnectionInFlight().getConnection().getChannel().config().setAutoRead(false);
+
+      if (connection.getState() == StateRegistry.PLAY || connection.getState() == StateRegistry.CONFIG) {
+        connection.write(new PluginMessagePacket("fml:handshake", Unpooled.wrappedBuffer(ForgeHandshakeUtils.generatePluginResetPacket())));
+        connection.setState(StateRegistry.LOGIN);
+      } else {
+        connection.write(new LoginPluginMessagePacket(98,"fml:loginwrapper", Unpooled.wrappedBuffer(ForgeHandshakeUtils.generateResetPacket())));
+      }
+
+      //Prepare to receive reset ACK
+      connection.getChannel().pipeline().addBefore(Connections.MINECRAFT_DECODER,
+              ForgeConstants.RESET_LISTENER, new FML2CRPMResetCompleteDecoder());
+
+      //Transition
+      player.setPhase(WAITING_RESET);
+      WAITING_RESET.onTransitionToNewPhase(player);
+    }
+
+    @Override
+    public boolean consideredComplete() {
+      return true;
+    }
+  },
+  WAITING_RESET {
     @Override
     void onTransitionToNewPhase(ConnectedPlayer player) {
       //We unregister so no plugin sees this client while the client is being reset.
@@ -58,8 +96,7 @@ public enum VelocityForgeClientConnectionPhase implements ClientConnectionPhase
 
     @Override
     public boolean handle(ConnectedPlayer player, IForgeLoginWrapperPacket msg, VelocityServerConnection server) {
-      if (msg.getContext().getResponseID() == 98) {
+      if (msg.getId() == 98) {
-        //Reset complete
         player.getConnection().getChannel().pipeline().remove(ForgeConstants.RESET_LISTENER);
         player.setPhase(NOT_STARTED);
 
@@ -67,10 +104,7 @@ public enum VelocityForgeClientConnectionPhase implements ClientConnectionPhase
 
         if (!(server.getConnection().getType() instanceof ForgeFMLConnectionType)) {
           // -> vanilla
-          complete(player, ((Context.ClientContext) msg.getContext()).success() ? ClientResetType.CRP : null);
+          complete(player, msg.getSuccess());
-        }
-
-        if (player.getConnectionInFlight() != null) {
           player.getConnectionInFlight().getConnection().getChannel().config().setAutoRead(true);
         }
 
@@ -81,15 +115,8 @@ public enum VelocityForgeClientConnectionPhase implements ClientConnectionPhase
     }
   },
   COMPLETE {
-
-    private ClientResetType resetType = ClientResetType.UNKNOWN;
     @Override
     void onTransitionToNewPhase(ConnectedPlayer player) {
-      //Send Login Success to client
-      MinecraftConnection connection = player.getConnection();
-      ((OutboundSuccessHolder) connection.getChannel().pipeline().get(ForgeConstants.SERVER_SUCCESS_LISTENER))
-              .sendPacket();
-      connection.setState(StateRegistry.PLAY);
       //Plugins may now send packets to client
       player.getConnection().getChannel().pipeline().remove(ForgeConstants.PLUGIN_PACKET_QUEUE);
       ((VelocityServer) Ambassador.getInstance().server).registerConnection(player);
@@ -97,49 +124,39 @@ public enum VelocityForgeClientConnectionPhase implements ClientConnectionPhase
 
     @Override
     public void resetConnectionPhase(ConnectedPlayer player) {
-      getResetType().doReset(player);
+      Ambassador.getTemporaryForced().put(player.getUsername(), player.getConnectionInFlight().getServer(),
+              Ambassador.getInstance().config.getServerSwitchCancellationTime(), TimeUnit.SECONDS);
+      //Disconnect - Reset
+      if(player.getModInfo().isPresent()
+              && player.getModInfo().get().getMods().stream().anyMatch((mod -> mod.getId().equals("serverredirect")
+              || mod.getId().equals("srvredirect:red")))
+              && player.getVirtualHost().isPresent()) {
+        ByteBuf buf = Unpooled.buffer();
+        ProtocolUtils.writeVarInt(buf, 0);
+        buf.writeBytes((player.getVirtualHost().get().getHostName() + ":"
+                + player.getVirtualHost().get().getPort()).getBytes(StandardCharsets.UTF_8));
+        player.getConnection().write(new PluginMessagePacket("srvredirect:red", buf));
+      } else {
+        player.disconnect(Ambassador.getInstance().config.getDisconnectResetMessage());
+      }
     }
 
     @Override
     public boolean consideredComplete() {
       return true;
     }
-
-    @Override
-    public void complete(ConnectedPlayer player) {
-      if (Ambassador.getInstance().config.isDebugMode()) {
-        player.sendMessage(Component.text("Not resetting"));
-      }
-    }
-
-    @Override
-    void setResetType(ConnectedPlayer player, ClientResetType resetType) {
-      this.resetType = resetType;
-      if (Ambassador.getInstance().config.isDebugMode()) {
-        player.sendMessage(Component.text("Reset type: " + this.resetType.toString()));
-      }
-    }
-
-    @Override
-    public ClientResetType getResetType() {
-      return resetType;
-    }
   };
 
-  //TODO: Make a new class that's linked to each player with these fields instead of having them in this phase class
+  public ModListReplyPacket clientModList;
-  public ForgeHandshake forgeHandshake = new ForgeHandshake();
 
-  public boolean handle(ConnectedPlayer player, IForgeLoginWrapperPacket<Context.ClientContext> msg, VelocityServerConnection server) {
+  public boolean handle(ConnectedPlayer player, IForgeLoginWrapperPacket msg, VelocityServerConnection server) {
-
+    player.setPhase(nextPhase());
-    if (msg.getContext().getChannelName().equals("zeta:main")) {
-      forgeHandshake.zetaFlagsPacket = (GenericForgeLoginWrapperPacket<Context.ClientContext>) msg;
-    }
 
     if (msg instanceof ModListReplyPacket replyPacket) {
       ModInfo modInfo = new ModInfo("FML2", replyPacket.getMods().stream().map(
               (v) -> new ModInfo.Mod(v,"1")).toList());
       player.setModInfo(modInfo);
-      forgeHandshake.setModListReplyPacket(replyPacket);
+      this.clientModList = replyPacket;
       if (!(server.getConnection().getType() instanceof ForgeFMLConnectionType)) {
         complete(player);
         player.getConnectionInFlight().getConnection().getChannel().config().setAutoRead(true);
@@ -148,31 +165,48 @@ public enum VelocityForgeClientConnectionPhase implements ClientConnectionPhase
       replyPacket.getChannels().put(MinecraftChannelIdentifier.from("ambassador:commands"),"1");
     }
 
-    player.getConnectionInFlight().getConnection().write(msg);
+    player.getConnectionInFlight().getConnection().write(msg.encode());
-
-    player.setPhase(nextPhase());
-    nextPhase().forgeHandshake = this.forgeHandshake;
-
     return true;
   }
-  public void complete(ConnectedPlayer player) {
+
-    complete(player, null);
+  public void sendVanillaModlist(ConnectedPlayer player) {
+    player.getConnection().write(new LoginPluginMessagePacket(0, "fml:loginwrapper",
+            Unpooled.wrappedBuffer(player.getConnection().getType() == ForgeConstants.ForgeFML3 ?
+                    ForgeHandshakeUtils.emptyModlistFML3 : ForgeHandshakeUtils.emptyModlistFML2)));
+
+    ForgeLoginWrapperDecoder decoder = (ForgeLoginWrapperDecoder) player.getConnection()
+            .getChannel().pipeline().get(ForgeConstants.FORGE_HANDSHAKE_DECODER);
+    decoder.registerLoginWrapperID(0);
   }
 
-  public void complete(ConnectedPlayer player, ClientResetType resetType) {
+  public void complete(ConnectedPlayer player) {
-    //Change phase to COMPLETE
+    complete(player, isResettable(player));
-    player.setPhase(COMPLETE);
+  }
-    COMPLETE.onTransitionToNewPhase(player);
-    COMPLETE.forgeHandshake = forgeHandshake;
-    if (resetType != null) {
-      COMPLETE.setResetType(player, resetType);
-    }
 
-    if (Ambassador.getInstance().config.isDebugMode()) {
+  public void complete(ConnectedPlayer player, boolean resettable) {
-      player.sendMessage(Component.text("Forge handshake complete"));
+    MinecraftConnection connection = player.getConnection();
+    ((OutboundSuccessHolder) connection.getChannel().pipeline().get(ForgeConstants.SERVER_SUCCESS_LISTENER))
+            .sendPacket();
+    connection.setState(StateRegistry.PLAY);
+
+    if (resettable) {
+      player.setPhase(RESETTABLE);
+      RESETTABLE.onTransitionToNewPhase(player);
+      RESETTABLE.clientModList = clientModList;
+    } else {
+      player.setPhase(COMPLETE);
+      COMPLETE.onTransitionToNewPhase(player);
+      COMPLETE.clientModList = clientModList;
     }
   }
 
+  private boolean isResettable(ConnectedPlayer player) {
+    if (player.getModInfo().isPresent()) {
+      return player.getModInfo().get().getMods().stream().anyMatch((mod -> mod.getId().equals("clientresetpacket")));
+    }
+    return false;
+  }
+
   void onTransitionToNewPhase(ConnectedPlayer player) {
 
   }
@@ -186,82 +220,5 @@ public enum VelocityForgeClientConnectionPhase implements ClientConnectionPhase
     return false;
   }
 
-  public ClientResetType getResetType() {
-    return COMPLETE.getResetType();
-  }
 
-  private ClientResetType getResetType(ConnectedPlayer player) {
-    if (Ambassador.getInstance().config.isDebugMode()) {
-      player.sendMessage(Component.text("Scanning modlist for client reset mods"));
-    }
-    if (player.getModInfo().isPresent()) {
-      if (player.getModInfo().get().getMods().stream().anyMatch((mod -> mod.getId().equals("clientresetpacket")))) {
-        return ClientResetType.CRP;
-      } else if (Ambassador.getInstance().config.getServerSwitchCancellationTime() >= 0 &&
-              player.getModInfo().get().getMods().stream().anyMatch((mod -> mod.getId().equals("serverredirect")
-                      || mod.getId().equals("srvredirect:red")))
-              && player.getVirtualHost().isPresent()) {
-        return ClientResetType.SR;
-      }
-    }
-    return ClientResetType.NONE;
-  }
-
-  void setResetType(ConnectedPlayer player, ClientResetType resetType) {
-    COMPLETE.setResetType(player, resetType);
-  }
-  public void updateResetType(ConnectedPlayer player) {
-    COMPLETE.setResetType(player, getResetType(player));
-  }
-
-  public enum ClientResetType {
-    UNKNOWN,
-    NONE,
-    CRP {
-      @Override
-      void doReset(ConnectedPlayer player) {
-        MinecraftConnection connection = player.getConnection();
-
-        //There is no going back even if the handshake fails. No reason to still be connected.
-        if (player.getConnectedServer() != null) {
-          player.getConnectedServer().disconnect();
-          player.setConnectedServer(null);
-        }
-        //Don't handle anything from the server until the reset has completed.
-        if (player.getConnectionInFlight() != null) {
-          player.getConnectionInFlight().getConnection().getChannel().config().setAutoRead(false);
-        }
-
-        if (connection.getState() == StateRegistry.PLAY || connection.getState() == StateRegistry.CONFIG) {
-          connection.write(new PluginMessagePacket("fml:handshake", Unpooled.wrappedBuffer(ForgeHandshakeUtils.generatePluginResetPacket())));
-          connection.setState(StateRegistry.LOGIN);
-        } else {
-          connection.write(new LoginPluginMessagePacket(98,"fml:loginwrapper", Unpooled.wrappedBuffer(ForgeHandshakeUtils.generateResetPacket())));
-        }
-
-        //Prepare to receive reset ACK
-        connection.getChannel().pipeline().addBefore(Connections.MINECRAFT_DECODER,
-                ForgeConstants.RESET_LISTENER, new FML2CRPMResetCompleteDecoder());
-
-        //Transition
-        player.setPhase(WAITING_RESET);
-        WAITING_RESET.onTransitionToNewPhase(player);
-      }
-    },
-    SR {
-      @Override
-      void doReset(ConnectedPlayer player) {
-        ByteBuf buf = Unpooled.buffer();
-        ProtocolUtils.writeVarInt(buf, 0);
-        buf.writeBytes((player.getVirtualHost().get().getHostName() + ":"
-                + player.getVirtualHost().get().getPort()).getBytes(StandardCharsets.UTF_8));
-        player.getConnection().write(new PluginMessagePacket("srvredirect:red", buf));
-
-        Ambassador.getInstance().reconnectSwitchPlayer(player);
-      }
-    };
-
-    void doReset(ConnectedPlayer player) {
-    }
-  }
 }

src/main/java/org/adde0109/ambassador/forge/packet/ACKPacket.java

@@ -1,27 +0,0 @@
-package org.adde0109.ambassador.forge.packet;
-
-import com.velocitypowered.proxy.protocol.ProtocolUtils;
-import io.netty.buffer.ByteBuf;
-import io.netty.buffer.Unpooled;
-
-public class ACKPacket implements IForgeLoginWrapperPacket<Context.ClientContext> {
-
-    private final Context.ClientContext context;
-
-    public ACKPacket(Context.ClientContext context) {
-        this.context = context;
-    }
-    @Override
-    public ByteBuf encode() {
-        ByteBuf buf = Unpooled.buffer();
-
-        ProtocolUtils.writeVarInt(buf, 99);
-
-        return buf;
-    }
-
-    @Override
-    public Context.ClientContext getContext() {
-        return context;
-    }
-}

src/main/java/org/adde0109/ambassador/forge/packet/ConfigDataPacket.java

@@ -1,43 +0,0 @@
-package org.adde0109.ambassador.forge.packet;
-
-import com.velocitypowered.proxy.protocol.ProtocolUtils;
-import io.netty.buffer.ByteBuf;
-import io.netty.buffer.Unpooled;
-
-public class ConfigDataPacket implements IForgeLoginWrapperPacket<Context> {
-
-    private final String fileName;
-    private final byte[] fileData;
-
-    private final Context context;
-
-    public ConfigDataPacket(String fileName, byte[] fileData, Context context) {
-        this.fileName = fileName;
-        this.fileData = fileData;
-        this.context = context;
-    }
-
-    public static ConfigDataPacket read(ByteBuf input, Context context, boolean FML3) {
-        String registryName = ProtocolUtils.readString(input);
-        byte[] snapshot = ProtocolUtils.readByteArray(input);
-
-        return new ConfigDataPacket(registryName, snapshot, context);
-    }
-
-    @Override
-    public ByteBuf encode() {
-        ByteBuf buf = Unpooled.buffer();
-
-        ProtocolUtils.writeVarInt(buf, 4);
-
-        ProtocolUtils.writeString(buf, fileName);
-        ProtocolUtils.writeByteArray(buf, fileData);
-
-        return buf;
-    }
-
-    @Override
-    public Context getContext() {
-        return context;
-    }
-}

src/main/java/org/adde0109/ambassador/forge/packet/Context.java

@@ -1,46 +0,0 @@
-package org.adde0109.ambassador.forge.packet;
-
-public class Context {
-
-  private final int responseID;
-
-  private final String channelName;
-
-  private Context(int responseID, String channelName) {
-    this.responseID = responseID;
-      this.channelName = channelName;
-  }
-
-  public static Context createContext(int responseID, String channelName) {
-    return new Context(responseID, channelName);
-  }
-
-  public static ClientContext createClientContext(int responseID, boolean clientSuccess, String channelName) {
-    return new ClientContext(responseID, clientSuccess, channelName);
-  }
-
-  public static ClientContext fromContext(Context context, boolean clientSuccess) {
-    return new ClientContext(context.responseID, clientSuccess, context.channelName);
-  }
-
-  public int getResponseID() {
-    return responseID;
-  }
-
-  public String getChannelName() {
-    return channelName;
-  }
-
-  public static class ClientContext extends Context {
-
-    private final boolean clientSuccess;
-    ClientContext(int responseID, boolean clientSuccess, String channelName) {
-      super(responseID, channelName);
-      this.clientSuccess = clientSuccess;
-    }
-
-    public boolean success() {
-      return clientSuccess;
-    }
-  }
-}

src/main/java/org/adde0109/ambassador/forge/packet/GenericForgeLoginWrapperPacket.java

@@ -1,39 +1,31 @@
 package org.adde0109.ambassador.forge.packet;
 
+import com.velocitypowered.proxy.protocol.packet.LoginPluginResponsePacket;
+import com.velocitypowered.proxy.protocol.util.DeferredByteBufHolder;
 import io.netty.buffer.ByteBuf;
-import io.netty.buffer.Unpooled;
 
-public class GenericForgeLoginWrapperPacket<T extends Context> implements IForgeLoginWrapperPacket<T> {
+public class GenericForgeLoginWrapperPacket extends DeferredByteBufHolder implements IForgeLoginWrapperPacket {
+  private final int id;
+  private final boolean success;
 
-  private final byte[] content;
+  public GenericForgeLoginWrapperPacket(ByteBuf input, int id, boolean success) {
-  private final T context;
+    super(input);
-
+    this.id = id;
-  public GenericForgeLoginWrapperPacket(byte[] content, T context) {
+    this.success = success;
-    this.content = content;
-    this.context = context;
-  }
-
-
-  static public GenericForgeLoginWrapperPacket<?> read(ByteBuf input, Context context) {
-    byte[] content = new byte[input.readableBytes()];
-    input.readBytes(content);
-    return new GenericForgeLoginWrapperPacket<>(content, context);
   }
 
   @Override
-  public ByteBuf encode() {
+  public LoginPluginResponsePacket encode() {
-    ByteBuf buf = Unpooled.buffer();
+    return new LoginPluginResponsePacket(id, true, content());
-    buf.writeBytes(content);
-    return buf;
-  }
-
-  public byte[] getContent() {
-    return content;
   }
 
   @Override
-  public T getContext() {
+  public int getId() {
-    return context;
+    return id;
   }
 
+  @Override
+  public boolean getSuccess() {
+    return success;
+  }
 }

src/main/java/org/adde0109/ambassador/forge/packet/IForgeLoginWrapperPacket.java

@@ -1,8 +1,10 @@
 package org.adde0109.ambassador.forge.packet;
 
-import io.netty.buffer.ByteBuf;
+import com.velocitypowered.proxy.protocol.packet.LoginPluginResponsePacket;
 
-public interface IForgeLoginWrapperPacket<T extends Context> {
+public interface IForgeLoginWrapperPacket {
-  ByteBuf encode();
+  public LoginPluginResponsePacket encode();
-  T getContext();
+  public int getId();
+
+  public boolean getSuccess();
 }

src/main/java/org/adde0109/ambassador/forge/packet/ModDataPacket.java

@@ -1,39 +0,0 @@
-package org.adde0109.ambassador.forge.packet;
-
-import com.velocitypowered.proxy.protocol.ProtocolUtils;
-import io.netty.buffer.ByteBuf;
-import io.netty.buffer.Unpooled;
-
-public class ModDataPacket implements IForgeLoginWrapperPacket<Context> {
-  private final byte[] content;
-  private final Context context;
-
-  ModDataPacket(byte[] content, Context context) {
-    this.content = content;
-    this.context = context;
-  }
-
-
-  static public ModDataPacket read(ByteBuf input, Context context) {
-    byte[] content = new byte[input.readableBytes()];
-    input.readBytes(content);
-    return new ModDataPacket(content, context);
-  }
-
-  @Override
-  public ByteBuf encode() {
-    ByteBuf buf = Unpooled.buffer();
-    ProtocolUtils.writeVarInt(buf, 5); //PacketID
-    buf.writeBytes(content);
-    return buf;
-  }
-
-  public byte[] getContent() {
-    return content;
-  }
-
-  @Override
-  public Context getContext() {
-    return context;
-  }
-}

src/main/java/org/adde0109/ambassador/forge/packet/ModListPacket.java

@@ -1,102 +0,0 @@
-package org.adde0109.ambassador.forge.packet;
-
-import com.velocitypowered.api.proxy.messages.ChannelIdentifier;
-import com.velocitypowered.api.proxy.messages.MinecraftChannelIdentifier;
-import com.velocitypowered.proxy.protocol.ProtocolUtils;
-import io.netty.buffer.ByteBuf;
-import io.netty.buffer.Unpooled;
-
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-
-public class ModListPacket implements IForgeLoginWrapperPacket<Context> {
-    private List<String> mods;
-    private Map<ChannelIdentifier, String> channels;
-    private List<String> registries;
-    private final List<String> dataPackRegistries;
-
-    private final Context context;
-    private ModListPacket(List<String> mods, Map<ChannelIdentifier,
-            String> channels, List<String> registries, Context context, List<String> dataPackRegistries) {
-        this.mods = mods;
-        this.channels = channels;
-        this.registries = registries;
-        this.context = context;
-        this.dataPackRegistries = dataPackRegistries;
-    }
-
-    public static ModListPacket read(ByteBuf input, Context context, boolean FML3) {
-
-        List<String> mods = new ArrayList<>();
-        int len = ProtocolUtils.readVarInt(input);
-        for (int x = 0; x < len; x++)
-            mods.add(ProtocolUtils.readString(input, 0x100));
-
-        Map<ChannelIdentifier, String> channels = new HashMap<>();
-        len = ProtocolUtils.readVarInt(input);
-        for (int x = 0; x < len; x++)
-            channels.put(MinecraftChannelIdentifier.from(ProtocolUtils.readString(input, 32767)),
-                    ProtocolUtils.readString(input, 0x100));
-
-        List<String> registries = new ArrayList<>();
-        len = ProtocolUtils.readVarInt(input);
-        for (int x = 0; x < len; x++)
-            registries.add(ProtocolUtils.readString(input, 32767));
-
-        List<String> dataPackRegistries = null;
-        if (FML3 && input.isReadable()) {
-            dataPackRegistries = new ArrayList<>();
-            len = ProtocolUtils.readVarInt(input);
-            for (int x = 0; x < len; x++)
-                dataPackRegistries.add(ProtocolUtils.readString(input, 0x100));
-        }
-
-        return new ModListPacket(mods, channels, registries, context, dataPackRegistries);
-    }
-
-    @Override
-    public ByteBuf encode() {
-        ByteBuf buf = Unpooled.buffer();
-
-        ProtocolUtils.writeVarInt(buf, 1);
-
-        ProtocolUtils.writeVarInt(buf, mods.size());
-        mods.forEach(m -> ProtocolUtils.writeString(buf, m));
-
-        ProtocolUtils.writeVarInt(buf, channels.size());
-        channels.forEach((k, v) -> {
-            ProtocolUtils.writeString(buf,k.getId());
-            ProtocolUtils.writeString(buf,v);
-        });
-
-        ProtocolUtils.writeVarInt(buf, registries.size());
-        registries.forEach(k -> ProtocolUtils.writeString(buf, k));
-
-        if (dataPackRegistries != null) {
-            ProtocolUtils.writeVarInt(buf, dataPackRegistries.size());
-            dataPackRegistries.forEach(k -> ProtocolUtils.writeString(buf, k));
-        }
-
-        return buf;
-    }
-
-    @Override
-    public Context getContext() {
-        return context;
-    }
-
-    public List<String> getMods() {
-        return mods;
-    }
-
-    public Map<ChannelIdentifier, String> getChannels() {
-        return channels;
-    }
-
-    public List<String> getRegistries() {
-        return registries;
-    }
-
-}

src/main/java/org/adde0109/ambassador/forge/packet/ModListReplyPacket.java

@@ -3,6 +3,7 @@ package org.adde0109.ambassador.forge.packet;
 import com.velocitypowered.api.proxy.messages.ChannelIdentifier;
 import com.velocitypowered.api.proxy.messages.MinecraftChannelIdentifier;
 import com.velocitypowered.proxy.protocol.ProtocolUtils;
+import com.velocitypowered.proxy.protocol.packet.LoginPluginResponsePacket;
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 
@@ -11,22 +12,27 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
-public class ModListReplyPacket implements IForgeLoginWrapperPacket<Context.ClientContext> {
+public class ModListReplyPacket implements IForgeLoginWrapperPacket {
 
   private List<String> mods;
   private Map<ChannelIdentifier, String> channels;
   private Map<String, String> registries;
 
-  private final Context.ClientContext context;
+  private final int id;
+
+  private final boolean success;
+
   private ModListReplyPacket(List<String> mods, Map<ChannelIdentifier,
-          String> channels, Map<String, String> registries, Context.ClientContext context) {
+          String> channels, Map<String, String> registries, int id, boolean success) {
     this.mods = mods;
     this.channels = channels;
     this.registries = registries;
-    this.context = context;
+    this.id = id;
+    this.success = success;
   }
 
-  public static ModListReplyPacket read(ByteBuf input, Context.ClientContext context) {
+  public static ModListReplyPacket read(LoginPluginResponsePacket msg) {
+    ByteBuf input = msg.content();
 
     List<String> mods = new ArrayList<>();
     int len = ProtocolUtils.readVarInt(input);
@@ -44,11 +50,11 @@ public class ModListReplyPacket implements IForgeLoginWrapperPacket<Context.Clie
     for (int x = 0; x < len; x++)
       registries.put(ProtocolUtils.readString(input, 32767), ProtocolUtils.readString(input, 0x100));
 
-    return new ModListReplyPacket(mods, channels, registries, context);
+    return new ModListReplyPacket(mods, channels, registries, msg.getId(), true);
   }
 
   @Override
-  public ByteBuf encode() {
+  public LoginPluginResponsePacket encode() {
     ByteBuf buf = Unpooled.buffer();
 
     ProtocolUtils.writeVarInt(buf, 2);
@@ -68,12 +74,22 @@ public class ModListReplyPacket implements IForgeLoginWrapperPacket<Context.Clie
       ProtocolUtils.writeString(buf, v);
     });
 
-    return buf;
+    ByteBuf output = Unpooled.buffer();
+    ProtocolUtils.writeString(output, "fml:handshake");
+    ProtocolUtils.writeVarInt(output, buf.readableBytes());
+    output.writeBytes(buf);
+
+    return new LoginPluginResponsePacket(id, true, output);
   }
 
   @Override
-  public Context.ClientContext getContext() {
+  public int getId() {
-    return context;
+    return id;
+  }
+
+  @Override
+  public boolean getSuccess() {
+    return success;
   }
 
   public List<String> getMods() {

src/main/java/org/adde0109/ambassador/forge/packet/RegistryPacket.java

@@ -1,60 +0,0 @@
-package org.adde0109.ambassador.forge.packet;
-
-import com.velocitypowered.proxy.protocol.ProtocolUtils;
-import io.netty.buffer.ByteBuf;
-import io.netty.buffer.Unpooled;
-
-public class RegistryPacket implements IForgeLoginWrapperPacket<Context> {
-
-  private final String registryName;
-
-  private final byte[] snapshot;
-
-  private final Context context;
-  public RegistryPacket(String registryName, byte[] snapshot, Context context) {
-    this.registryName = registryName;
-    this.snapshot = snapshot;
-    this.context = context;
-  }
-
-  public static RegistryPacket read(ByteBuf input, Context context, boolean FML3) {
-    String registryName = ProtocolUtils.readString(input);
-    byte[] snapshot = null;
-    if (input.readBoolean()) {
-      snapshot = new byte[input.readableBytes()];
-      input.readBytes(snapshot);
-    }
-
-    return new RegistryPacket(registryName, snapshot, context);
-  }
-
-  @Override
-  public ByteBuf encode() {
-    ByteBuf buf = Unpooled.buffer();
-
-    ProtocolUtils.writeVarInt(buf, 3);
-
-    ProtocolUtils.writeString(buf, registryName);
-    if (snapshot != null) {
-      buf.writeBoolean(true);
-      buf.writeBytes(snapshot);
-    } else {
-      buf.writeBoolean(false);
-    }
-
-    return buf;
-  }
-
-  @Override
-  public Context getContext() {
-    return context;
-  }
-
-  public String getRegistryName() {
-    return registryName;
-  }
-
-  public byte[] getSnapshot() {
-    return snapshot;
-  }
-}

src/main/java/org/adde0109/ambassador/forge/pipeline/ForgeLoginWrapperCodec.java

@@ -1,146 +0,0 @@
-package org.adde0109.ambassador.forge.pipeline;
-
-import com.velocitypowered.proxy.protocol.ProtocolUtils;
-import com.velocitypowered.proxy.protocol.packet.LoginPluginMessagePacket;
-import com.velocitypowered.proxy.protocol.packet.LoginPluginResponsePacket;
-import com.velocitypowered.proxy.protocol.util.DeferredByteBufHolder;
-import io.netty.buffer.ByteBuf;
-import io.netty.buffer.Unpooled;
-import io.netty.channel.ChannelHandlerContext;
-import io.netty.handler.codec.DecoderException;
-import io.netty.handler.codec.MessageToMessageCodec;
-import io.netty.util.ReferenceCountUtil;
-import org.adde0109.ambassador.Ambassador;
-import org.adde0109.ambassador.forge.packet.*;
-
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-
-public class ForgeLoginWrapperCodec extends MessageToMessageCodec<DeferredByteBufHolder, IForgeLoginWrapperPacket<?>> {
-
-  private final boolean FML3;
-  private final Map<Integer, Context> loginWrapperContexts = new HashMap<>();
-
-  public ForgeLoginWrapperCodec(boolean fml3) {
-    FML3 = fml3;
-  }
-
-  @Override
-  public boolean acceptInboundMessage(Object msg) throws Exception {
-    return (msg instanceof LoginPluginMessagePacket
-            && ((LoginPluginMessagePacket) msg).getChannel().equals("fml:loginwrapper"))
-            || (msg instanceof LoginPluginResponsePacket
-            && loginWrapperContexts.containsKey(((LoginPluginResponsePacket) msg).getId()));
-  }
-
-  @Override
-  protected void decode(ChannelHandlerContext ctx, DeferredByteBufHolder in, List<Object> out) throws Exception {
-
-    ByteBuf buf = in.content();
-
-    Context context;
-    if (in instanceof LoginPluginResponsePacket msg) {
-      //Continue from stored context
-      context = Context.fromContext(
-              loginWrapperContexts.remove(((LoginPluginResponsePacket) msg).getId()), msg.isSuccess());
-      if (!msg.isSuccess()) {
-        //Nothing to read, just create an empty packet.
-        out.add(GenericForgeLoginWrapperPacket.read(buf, context));
-        return;
-      } else {
-        String channel = ProtocolUtils.readString(buf); //Read the channel even though we know the channel by context.
-        Ambassador.getInstance();
-      }
-    } else {
-      //New context.
-      LoginPluginMessagePacket msg = (LoginPluginMessagePacket) in;
-      String channel = ProtocolUtils.readString(buf);
-
-      context = Context.createContext(msg.getId(), channel);
-    }
-
-    //Decoding of data starts here - channel already read
-    int originalReaderIndex = buf.readerIndex();
-
-    if (!context.getChannelName().equals("fml:handshake")) {
-      out.add(GenericForgeLoginWrapperPacket.read(buf, context));
-    } else {
-      int length = ProtocolUtils.readVarInt(buf);
-      int packetID = ProtocolUtils.readVarInt(buf);
-      if (context instanceof Context.ClientContext clientContext) {
-        switch (packetID) {
-          case 2:
-            out.add(ModListReplyPacket.read(buf, clientContext));
-            break;
-          case 99:
-            out.add(new ACKPacket(clientContext));
-            break;
-          default:
-            //Undo decoding
-            buf.readerIndex(originalReaderIndex);
-            out.add(GenericForgeLoginWrapperPacket.read(buf, context));
-            if (Ambassador.getInstance().config.isDebugMode()) {
-              Ambassador.getInstance().logger.warn(
-                      "Unrecognised packet id received from client on fml:handshake: " + packetID);
-            }
-        }
-      } else {
-        switch (packetID) {
-          case 1:
-            out.add(ModListPacket.read(buf, context, FML3));
-            break;
-          case 3:
-            out.add(RegistryPacket.read(buf, context, FML3));
-            break;
-          case 4:
-            out.add(ConfigDataPacket.read(buf, context, FML3));
-            break;
-          case 5:
-            if (FML3) {
-              out.add(ModDataPacket.read(buf, context));
-              break;
-            }
-          default:
-            //Undo decoding
-            buf.readerIndex(originalReaderIndex);
-            out.add(GenericForgeLoginWrapperPacket.read(buf, context));
-            if (Ambassador.getInstance().config.isDebugMode()) {
-              Ambassador.getInstance().logger.warn(
-                      "Unrecognised packet id received from server on fml:handshake: " + packetID);
-            }
-        }
-      }
-    }
-  }
-
-  @Override
-  protected void encode(ChannelHandlerContext ctx, IForgeLoginWrapperPacket<?> msg, List<Object> out) throws Exception {
-    ByteBuf wrapped;
-
-    boolean data = !(msg.getContext() instanceof Context.ClientContext clientContext && !clientContext.success());
-
-    boolean includeLength = !(msg instanceof GenericForgeLoginWrapperPacket);
-
-    String channel = msg.getContext().getChannelName();
-
-    wrapped = Unpooled.buffer();
-
-    if (data) {
-      ByteBuf encoded = msg.encode();
-      ProtocolUtils.writeString(wrapped, channel);
-      if (includeLength)
-        ProtocolUtils.writeVarInt(wrapped, encoded.readableBytes());
-      wrapped.writeBytes(encoded);
-      encoded.release();
-    }
-    if (msg.getContext() instanceof Context.ClientContext clientContext) {
-      out.add(new LoginPluginResponsePacket(clientContext.getResponseID(), clientContext.success(), wrapped));
-    } else {
-      out.add(new LoginPluginMessagePacket(msg.getContext().getResponseID(), "fml:loginwrapper", wrapped));
-      if (!(msg instanceof ModDataPacket)) {  //ModDataPacket doesn't require a response
-        this.loginWrapperContexts.put(msg.getContext().getResponseID(), msg.getContext());
-      }
-    }
-  }
-}

src/main/java/org/adde0109/ambassador/forge/pipeline/ForgeLoginWrapperDecoder.java

@@ -0,0 +1,45 @@
+package org.adde0109.ambassador.forge.pipeline;
+
+import com.velocitypowered.proxy.protocol.ProtocolUtils;
+import com.velocitypowered.proxy.protocol.packet.LoginPluginResponsePacket;
+import io.netty.buffer.ByteBuf;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.handler.codec.MessageToMessageDecoder;
+import org.adde0109.ambassador.forge.packet.GenericForgeLoginWrapperPacket;
+import org.adde0109.ambassador.forge.packet.ModListReplyPacket;
+
+import java.util.ArrayList;
+import java.util.List;
+
+public class ForgeLoginWrapperDecoder extends MessageToMessageDecoder<LoginPluginResponsePacket> {
+
+  private final List<Integer> loginWrapperIDs = new ArrayList<>();
+
+  @Override
+  protected void decode(ChannelHandlerContext ctx, LoginPluginResponsePacket msg, List<Object> out) throws Exception {
+    ByteBuf buf = msg.content();
+    if (!loginWrapperIDs.remove((Integer) msg.getId())) {
+      out.add(msg.retain());
+      return;
+    }
+    int originalReaderIndex = msg.content().readerIndex();
+    String channel = ProtocolUtils.readString(buf);
+    if (!channel.equals("fml:handshake")) {
+      buf.readerIndex(originalReaderIndex);
+      out.add(new GenericForgeLoginWrapperPacket(buf.retain(), msg.getId(), true));
+      return;
+    }
+    int length = ProtocolUtils.readVarInt(buf);
+    int packetID = ProtocolUtils.readVarInt(buf);
+    if (packetID == 2) {
+      out.add(ModListReplyPacket.read(msg));
+    } else {
+      buf.readerIndex(originalReaderIndex);
+      out.add(new GenericForgeLoginWrapperPacket(buf.retain(), msg.getId(), true));
+    }
+  }
+
+  public void registerLoginWrapperID(int loginWrapperID) {
+    this.loginWrapperIDs.add(loginWrapperID);
+  }
+}

src/main/java/org/adde0109/ambassador/forge/pipeline/ForgeLoginWrapperHandler.java

@@ -1,42 +1,25 @@
 package org.adde0109.ambassador.forge.pipeline;
 
-import com.velocitypowered.proxy.connection.MinecraftConnectionAssociation;
-import com.velocitypowered.proxy.connection.backend.VelocityServerConnection;
 import com.velocitypowered.proxy.connection.client.ConnectedPlayer;
 import io.netty.channel.ChannelHandlerContext;
 import io.netty.channel.SimpleChannelInboundHandler;
 import io.netty.util.ReferenceCountUtil;
-import org.adde0109.ambassador.forge.ForgeConstants;
-import org.adde0109.ambassador.forge.ForgeFMLConnectionType;
-import org.adde0109.ambassador.forge.VelocityForgeBackendConnectionPhase;
-import org.adde0109.ambassador.forge.packet.Context;
 import org.adde0109.ambassador.forge.packet.IForgeLoginWrapperPacket;
 import org.adde0109.ambassador.forge.VelocityForgeClientConnectionPhase;
 
-public class ForgeLoginWrapperHandler extends SimpleChannelInboundHandler<IForgeLoginWrapperPacket<?>> {
+public class ForgeLoginWrapperHandler extends SimpleChannelInboundHandler<IForgeLoginWrapperPacket> {
 
-  private final MinecraftConnectionAssociation connection;
+  private final ConnectedPlayer player;
 
 
-  public ForgeLoginWrapperHandler(MinecraftConnectionAssociation connection) {
+  public ForgeLoginWrapperHandler(ConnectedPlayer player) {
     super(false);
-    this.connection = connection;
+    this.player = player;
   }
 
   @Override
   protected void channelRead0(ChannelHandlerContext ctx, IForgeLoginWrapperPacket msg) throws Exception {
-    if (connection instanceof ConnectedPlayer player) {
       VelocityForgeClientConnectionPhase phase = (VelocityForgeClientConnectionPhase) player.getPhase();
       phase.handle(player,msg,player.getConnectionInFlight());
-    } else if (connection instanceof VelocityServerConnection serverConnection){
-      if (!(serverConnection.getConnection().getType() instanceof ForgeFMLConnectionType)) {
-        serverConnection.getConnection().setType(serverConnection.getPlayer().getConnection().getType());
-        serverConnection.setConnectionPhase(serverConnection.getConnection().getType().getInitialBackendPhase());
-      }
-
-      VelocityForgeBackendConnectionPhase phase =
-              (VelocityForgeBackendConnectionPhase) serverConnection.getPhase();
-      phase.handle(serverConnection, serverConnection.getPlayer(), msg);
-    }
   }
 }

src/main/java/org/adde0109/ambassador/velocity/VelocityEventHandler.java

@@ -3,6 +3,7 @@ package org.adde0109.ambassador.velocity;
 import com.velocitypowered.api.event.Continuation;
 import com.velocitypowered.api.event.PostOrder;
 import com.velocitypowered.api.event.Subscribe;
+import com.velocitypowered.api.event.connection.LoginEvent;
 import com.velocitypowered.api.event.connection.PostLoginEvent;
 import com.velocitypowered.api.event.player.*;
 import com.velocitypowered.api.proxy.server.RegisteredServer;
@@ -11,11 +12,12 @@ import com.velocitypowered.proxy.VelocityServer;
 import com.velocitypowered.proxy.connection.client.ConnectedPlayer;
 import com.velocitypowered.proxy.network.Connections;
 import com.velocitypowered.proxy.protocol.StateRegistry;
+import net.kyori.adventure.text.Component;
 import org.adde0109.ambassador.Ambassador;
 import org.adde0109.ambassador.forge.ForgeConstants;
 import org.adde0109.ambassador.forge.ForgeFMLConnectionType;
 import org.adde0109.ambassador.forge.VelocityForgeClientConnectionPhase;
-import org.adde0109.ambassador.forge.pipeline.ForgeLoginWrapperCodec;
+import org.adde0109.ambassador.forge.pipeline.ForgeLoginWrapperDecoder;
 import org.adde0109.ambassador.forge.pipeline.ForgeLoginWrapperHandler;
 
 public class VelocityEventHandler {
@@ -37,8 +39,7 @@ public class VelocityEventHandler {
 
         player.getConnection().getChannel().pipeline().addBefore(
                 Connections.HANDLER,
-                ForgeConstants.FORGE_HANDSHAKE_DECODER, new ForgeLoginWrapperCodec(
+                ForgeConstants.FORGE_HANDSHAKE_DECODER, new ForgeLoginWrapperDecoder());
-                        player.getConnection().getType() == ForgeConstants.ForgeFML3));
         player.getConnection().getChannel().pipeline().addAfter(
                 ForgeConstants.FORGE_HANDSHAKE_DECODER,
                 ForgeConstants.FORGE_HANDSHAKE_HANDLER, new ForgeLoginWrapperHandler(player));
@@ -71,12 +72,6 @@ public class VelocityEventHandler {
     player.setModInfo(new ModInfo("Channels", event.getChannels().stream().map((id) -> {
       return new ModInfo.Mod(id.getId(), "");
     }).toList()));
-
-    VelocityForgeClientConnectionPhase clientPhase = (VelocityForgeClientConnectionPhase) player.getPhase();
-    //If reset typ is still unknown, set it!
-    if (clientPhase.getResetType() == VelocityForgeClientConnectionPhase.ClientResetType.UNKNOWN) {
-      clientPhase.updateResetType(player);
-    }
   }
 
 }

src/main/java/org/adde0109/ambassador/velocity/backend/ForgeLoginSessionHandler.java

@@ -25,22 +25,40 @@ public class ForgeLoginSessionHandler implements MinecraftSessionHandler {
     this.server = server;
   }
 
+  @Override
+  public boolean handle(LoginPluginMessagePacket packet) {
+    if (packet.getChannel().equals("fml:loginwrapper")) {
+      if (serverConnection.getPhase() == BackendConnectionPhases.UNKNOWN) {
+        VelocityForgeBackendConnectionPhase.NOT_STARTED.handle(serverConnection,serverConnection.getPlayer(),packet);
+      } else if (serverConnection.getPhase() instanceof VelocityForgeBackendConnectionPhase phase1) {
+        phase1.handle(serverConnection,serverConnection.getPlayer(),packet);
+      }
+      return true;
+    }
+    return original.handle(packet);
+  }
+
   @Override
   public boolean handle(ServerLoginSuccessPacket packet) {
     if ((serverConnection.getPhase() instanceof VelocityForgeBackendConnectionPhase phase)) {
       phase.onLoginSuccess(serverConnection,serverConnection.getPlayer());
     }
-
+    original.handle(packet);
-    original.handle(packet);  //Can lead to disconnect.
+    if (serverConnection.getConnection() == null) {
-
+      return true;
-    //If we are still connected after handling that package.
+    }
-    if (serverConnection.getConnection() != null) {
+    ConnectedPlayer player = serverConnection.getPlayer();
-      ConnectedPlayer player = serverConnection.getPlayer();
+    if (!(serverConnection.getConnection().getType() instanceof ForgeFMLConnectionType)) {
-
+      if (player.getConnectedServer() == null ||
-      VelocityForgeClientConnectionPhase clientPhase = (VelocityForgeClientConnectionPhase) player.getPhase();
+              player.getConnectedServer().getConnection().getType() instanceof ForgeFMLConnectionType) {
-      clientPhase.complete(player);
+        //Initial Vanilla
+        //Forge -> vanilla
+        player.getPhase().resetConnectionPhase(player);
+        player.getConnectionInFlight().getConnection().getChannel().config().setAutoRead(false);
+      }
+    } else {
+      ((VelocityForgeClientConnectionPhase) player.getPhase()).complete(player);
     }
-
     return true;
   }
 
@@ -48,11 +66,31 @@ public class ForgeLoginSessionHandler implements MinecraftSessionHandler {
 
   @Override
   public boolean handle(DisconnectPacket packet) {
+    if (!serverConnection.getPlayer().getPhase().consideredComplete()) {
+      serverConnection.getPlayer().handleConnectionException(serverConnection.getServer(), packet, false);
+      return true;
+    }
     return original.handle(packet);
   }
 
   @Override
   public void disconnected() {
+    //Same as default just not safe.
+    if (!serverConnection.getPlayer().getPhase().consideredComplete()) {
+      if (server.getConfiguration().getPlayerInfoForwardingMode() == PlayerInfoForwarding.LEGACY) {
+        serverConnection.getPlayer().handleConnectionException(serverConnection.getServer(),
+                new QuietRuntimeException("The connection to the remote server was unexpectedly closed.\n"
+                        + "This is usually because the remote server does not have BungeeCord IP forwarding "
+                        + "correctly enabled.\nSee https://velocitypowered.com/wiki/users/forwarding/ "
+                        + "for instructions on how to configure player info forwarding correctly."),
+        false);
+      } else {
+        serverConnection.getPlayer().handleConnectionException(serverConnection.getServer(),
+                new QuietRuntimeException("The connection to the remote server was unexpectedly closed."),
+        false);
+      }
+      return;
+    }
       original.disconnected();
   }
 

src/main/java/org/adde0109/ambassador/velocity/backend/ForgePlaySessionHandler.java

@@ -0,0 +1,41 @@
+package org.adde0109.ambassador.velocity.backend;
+
+import com.velocitypowered.proxy.connection.MinecraftSessionHandler;
+import com.velocitypowered.proxy.connection.backend.TransitionSessionHandler;
+import com.velocitypowered.proxy.connection.backend.VelocityServerConnection;
+import com.velocitypowered.proxy.protocol.MinecraftPacket;
+import com.velocitypowered.proxy.protocol.packet.JoinGamePacket;
+import org.adde0109.ambassador.forge.VelocityForgeClientConnectionPhase;
+
+public class ForgePlaySessionHandler implements MinecraftSessionHandler {
+
+  private final TransitionSessionHandler original;
+  private final VelocityServerConnection serverConnection;
+
+  public ForgePlaySessionHandler(TransitionSessionHandler original, VelocityServerConnection serverConnection) {
+    this.original = original;
+    this.serverConnection = serverConnection;
+  }
+
+  @Override
+  public boolean handle(JoinGamePacket packet) {
+    if (serverConnection.getPlayer().getPhase() instanceof VelocityForgeClientConnectionPhase clientPhase) {
+      serverConnection.getPlayer().setPhase(VelocityForgeClientConnectionPhase.RESETTABLE);
+    }
+    return MinecraftSessionHandler.super.handle(packet);
+  }
+
+  @Override
+  public void disconnected() {
+    original.disconnected();
+  }
+
+  public void handleGeneric(MinecraftPacket packet) {
+    if (!packet.handle(original))
+      original.handleGeneric(packet);
+  }
+
+  public MinecraftSessionHandler getOriginal() {
+    return this.original;
+  }
+}

src/main/java/org/adde0109/ambassador/velocity/backend/VelocityForgeBackendHandshakeHandler.java

@@ -4,14 +4,10 @@ import com.velocitypowered.proxy.VelocityServer;
 import com.velocitypowered.proxy.connection.MinecraftConnection;
 import com.velocitypowered.proxy.connection.backend.LoginSessionHandler;
 import com.velocitypowered.proxy.connection.backend.VelocityServerConnection;
-import com.velocitypowered.proxy.connection.client.ConnectedPlayer;
 import com.velocitypowered.proxy.network.Connections;
 import com.velocitypowered.proxy.protocol.StateRegistry;
 import io.netty.channel.*;
-import org.adde0109.ambassador.forge.ForgeConstants;
 import org.adde0109.ambassador.forge.ForgeFMLConnectionType;
-import org.adde0109.ambassador.forge.pipeline.ForgeLoginWrapperCodec;
-import org.adde0109.ambassador.forge.pipeline.ForgeLoginWrapperHandler;
 import org.jetbrains.annotations.NotNull;
 
 public class VelocityForgeBackendHandshakeHandler extends ChannelInboundHandlerAdapter {
@@ -29,18 +25,9 @@ public class VelocityForgeBackendHandshakeHandler extends ChannelInboundHandlerA
 
     ctx.pipeline().remove(this);
 
-    ConnectedPlayer player = serverConnection.getPlayer();
+    if (serverConnection.getPlayer().getConnection().getType() instanceof ForgeFMLConnectionType) {
-    if (player.getConnection().getType() instanceof ForgeFMLConnectionType) {
       ForgeLoginSessionHandler forgeLoginSessionHandler = new ForgeLoginSessionHandler((LoginSessionHandler) connection.getActiveSessionHandler(), serverConnection,server);
       connection.setActiveSessionHandler(StateRegistry.LOGIN, forgeLoginSessionHandler);
-
-      serverConnection.getConnection().getChannel().pipeline().addBefore(
-              Connections.HANDLER,
-              ForgeConstants.FORGE_HANDSHAKE_DECODER, new ForgeLoginWrapperCodec(
-                      player.getConnection().getType() == ForgeConstants.ForgeFML3));
-      serverConnection.getConnection().getChannel().pipeline().addAfter(
-              ForgeConstants.FORGE_HANDSHAKE_DECODER,
-              ForgeConstants.FORGE_HANDSHAKE_HANDLER, new ForgeLoginWrapperHandler(serverConnection));
     }
 
     ctx.pipeline().fireChannelActive();

src/main/java/org/adde0109/ambassador/velocity/client/FML2CRPMResetCompleteDecoder.java

@@ -5,7 +5,6 @@ import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import io.netty.channel.ChannelHandlerContext;
 import io.netty.channel.ChannelInboundHandlerAdapter;
-import org.adde0109.ambassador.forge.packet.Context;
 import org.adde0109.ambassador.forge.packet.GenericForgeLoginWrapperPacket;
 import org.adde0109.ambassador.forge.packet.IForgeLoginWrapperPacket;
 
@@ -21,20 +20,34 @@ public class FML2CRPMResetCompleteDecoder extends ChannelInboundHandlerAdapter {
 
       int originalReaderIndex = buf.readerIndex();
       int packetId = ProtocolUtils.readVarInt(buf);
-      if (packetId == 0x02 && buf.readableBytes() > 1) {
+      if (packetId != 0x02) {
+        buf.release();
+        return;
+      }
+      if (buf.readableBytes() > 1) {
         try {
           int id = ProtocolUtils.readVarInt(buf);
           boolean success = buf.readBoolean();
           if (id == 98) {
             try {
-              ctx.fireChannelRead(GenericForgeLoginWrapperPacket.read(
+              int remainingBytes = buf.readableBytes();
-                      Unpooled.EMPTY_BUFFER, Context.createClientContext(id, success, "fml:handshake")));
+              if (remainingBytes > 0) {
-            } finally {
+                ByteBuf remainingData = Unpooled.buffer(remainingBytes);
-              buf.release();
+                remainingData.writeBytes(buf, remainingBytes);
+                IForgeLoginWrapperPacket packet = new GenericForgeLoginWrapperPacket(remainingData, id, success);
+                ctx.fireChannelRead(packet);
+              } else {
+                IForgeLoginWrapperPacket packet = new GenericForgeLoginWrapperPacket(Unpooled.EMPTY_BUFFER, id, success);
+                ctx.fireChannelRead(packet);
+              }
+            } catch (Exception e) {
+              System.err.println("[Ambassador] Error creating FML2CRPM packet: " + e.getMessage());
             }
+            buf.release();
             return;
           }
-        } catch (Exception ignored) {}
+        } catch (Exception ignored) {
+        }
       }
       buf.readerIndex(originalReaderIndex);
     }

src/main/java/org/adde0109/ambassador/velocity/client/VelocityHandshakeSessionHandler.java

@@ -26,17 +26,19 @@ public class VelocityHandshakeSessionHandler extends HandshakeSessionHandler  {
     handshake.handle(original);
     if (connection.getType() == ConnectionTypes.VANILLA) {
       final String[] markerSplit = handshake.getServerAddress().split("\0");
-      if (connection.getState() == StateRegistry.LOGIN && markerSplit.length > 1 && markerSplit[1].startsWith("FML")) {
+      if (connection.getState() == StateRegistry.LOGIN && markerSplit.length > 1) {
         switch (markerSplit[1]) {
           case "FML2":
             connection.setType(ForgeConstants.ForgeFML2);
+            connection.getChannel().pipeline().addAfter(Connections.MINECRAFT_ENCODER,ForgeConstants.SERVER_SUCCESS_LISTENER, new OutboundSuccessHolder());
+            connection.getChannel().pipeline().addAfter(Connections.MINECRAFT_ENCODER,ForgeConstants.PLUGIN_PACKET_QUEUE, new ClientPacketQueue(StateRegistry.LOGIN));
             break;
           case "FML3":
             connection.setType(ForgeConstants.ForgeFML3);
+            connection.getChannel().pipeline().addAfter(Connections.MINECRAFT_ENCODER,ForgeConstants.SERVER_SUCCESS_LISTENER, new OutboundSuccessHolder());
+            connection.getChannel().pipeline().addAfter(Connections.MINECRAFT_ENCODER,ForgeConstants.PLUGIN_PACKET_QUEUE, new ClientPacketQueue(StateRegistry.LOGIN));
             break;
         }
-        connection.getChannel().pipeline().addAfter(Connections.MINECRAFT_ENCODER,ForgeConstants.SERVER_SUCCESS_LISTENER, new OutboundSuccessHolder());
-        connection.getChannel().pipeline().addAfter(Connections.MINECRAFT_ENCODER,ForgeConstants.PLUGIN_PACKET_QUEUE, new ClientPacketQueue(StateRegistry.LOGIN));
       }
     }
     return true;

src/main/resources/default-ambassador.toml

@@ -1,29 +1,9 @@
 # Do not change this
-config-version = "2.1"
+config-version = "1.1"
 
+# Message displayed to the player when disconnected from proxy during server switch.
+# Legacy color codes and JSON are accepted.
+disconnect-reset-message = "&6Please reconnect"
 # How much time the player has to reconnect before canceling the server switch. (In seconds)
-# Only for players with ServerRedirect mod installed. Set to -1 to disable ServerRedirect mod support.
+server-switch-cancellation-time = 120
-serverRedirectTimeout = 30
-
-# Silence PCF absence warnings.
 silence-warnings = false
-
-# Allow server switches without reset even though the new server's registries don't match the old server’s registry.
-# Large modpacks often needs this set to true. Warning: This is a safety measure and setting this to true
-# can lead to unstable behaviour.
-bypass-registry-checks = false
-
-# Allow player to switch without reset when the server's mods don't match. Even more unstable than bypassRegistryCheck.
-# Warning: This is a safety measure for when bypassRegistryCheck is true. Setting this to also true can cause crashes.
-bypass-mod-checks = false
-
-# Only for debug/troubleshooting
-debug-mode = false
-
-# Make the player reconnect when server switching as a last resort if
-# the player can't reset or switch servers without resetting.
-enable-kick-reset = false
-
-# Message to display when player gets kicked due to server switching according to enable-kick-reset.
-# This input is deserialzied as MiniMessage and support formating according to the MiniMessage format.
-reconnect-message = "<red>Please reconnect.</red>"