From 999167e11e2b36fa0cf3c30f63fd0d0ad8ffa917 Mon Sep 17 00:00:00 2001
From: Pig Fang <g-plane@hotmail.com>
Date: Mon, 27 Jan 2020 11:50:29 +0800
Subject: [PATCH] fix hooks deps

---
 resources/assets/src/components/Modal.tsx                | 3 +--
 .../assets/src/views/admin/PluginsManagement/InfoBox.tsx | 4 ++--
 resources/assets/tests/components/Modal.test.tsx         | 9 ++++++++-
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/resources/assets/src/components/Modal.tsx b/resources/assets/src/components/Modal.tsx
index 21678959..5fb8fa4f 100644
--- a/resources/assets/src/components/Modal.tsx
+++ b/resources/assets/src/components/Modal.tsx
@@ -74,7 +74,6 @@ const Modal = React.forwardRef<HTMLDivElement, ModalOptions & Props>(
 
     useEffect(() => {
       const onHide = () => {
-        /* istanbul ignore else */
         if (!hidden) {
           dismiss()
         }
@@ -87,7 +86,7 @@ const Modal = React.forwardRef<HTMLDivElement, ModalOptions & Props>(
       return () => {
         el.off('hide.bs.modal', onHide).off('hidden.bs.modal', onHidden)
       }
-    }, [])
+    }, [hidden, props.onDismiss])
 
     return (
       <div
diff --git a/resources/assets/src/views/admin/PluginsManagement/InfoBox.tsx b/resources/assets/src/views/admin/PluginsManagement/InfoBox.tsx
index af87ac8a..e02d6b73 100644
--- a/resources/assets/src/views/admin/PluginsManagement/InfoBox.tsx
+++ b/resources/assets/src/views/admin/PluginsManagement/InfoBox.tsx
@@ -24,12 +24,12 @@ const InfoBox: React.FC<Props> = props => {
         props.onDisable(plugin)
       }
     },
-    [],
+    [plugin],
   )
 
   const handleDelete = useCallback(() => {
     props.onDelete(plugin)
-  }, [])
+  }, [plugin])
 
   return (
     <div className={`info-box mr-3 ${styles.box}`}>
diff --git a/resources/assets/tests/components/Modal.test.tsx b/resources/assets/tests/components/Modal.test.tsx
index fcddd081..41a9725c 100644
--- a/resources/assets/tests/components/Modal.test.tsx
+++ b/resources/assets/tests/components/Modal.test.tsx
@@ -32,7 +32,14 @@ test('forward ref', () => {
 
 test('jQuery events', () => {
   const ref = React.createRef<HTMLDivElement>()
-  render(<Modal ref={ref} show />)
+  const { getByText } = render(<Modal ref={ref} mode="confirm" show />)
+  act(() => {
+    $(ref.current!)
+      .trigger('hide.bs.modal')
+      .trigger('hidden.bs.modal')
+  })
+
+  fireEvent.click(getByText(trans('general.cancel')))
   act(() => {
     $(ref.current!)
       .trigger('hide.bs.modal')