Leisuretimedock/blessing-skin-server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

optimize for loop in test

Browse Source
This commit is contained in:
Pig Fang 2018-07-16 16:01:58 +08:00
parent 29c004da9c
commit 556f8268f3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/SkinlibControllerTest.php
View File

@ -239,7 +239,7 @@ class SkinlibControllerTest extends TestCase
]); ]);
// Other users should not see someone's private textures // Other users should not see someone's private textures
for ($i = 0; $i < count($expected); $i++) { for ($i = 0, $length = count($expected); $i < $length; $i++) {
$expected[$i]['liked'] = false; $expected[$i]['liked'] = false;
} }
$this->actAs($otherUser) $this->actAs($otherUser)
@ -258,7 +258,7 @@ class SkinlibControllerTest extends TestCase
$closet = new Closet($otherUser->uid); $closet = new Closet($otherUser->uid);
$closet->add($texture->tid, $texture->name); $closet->add($texture->tid, $texture->name);
$closet->save(); $closet->save();
for ($i = 0; $i < count($expected); $i++) { for ($i = 0, $length = count($expected); $i < $length; $i++) {
if ($expected[$i]['tid'] == $texture->tid) { if ($expected[$i]['tid'] == $texture->tid) {
$expected[$i]['liked'] = true; $expected[$i]['liked'] = true;
} else { } else {
@ -279,7 +279,7 @@ class SkinlibControllerTest extends TestCase
->values() ->values()
->forPage(1, 20); ->forPage(1, 20);
$expected = $this->serializeTextures($expected); $expected = $this->serializeTextures($expected);
for ($i = 0; $i < count($expected); $i++) { for ($i = 0, $length = count($expected); $i < $length; $i++) {
// The reason we use `false` here is that some textures just were // The reason we use `false` here is that some textures just were
// uploaded by this user, but these textures are not in his closet. // uploaded by this user, but these textures are not in his closet.
// By default(not in testing like now), when you uploaded a texture, // By default(not in testing like now), when you uploaded a texture,