check before unlink a non-existent file

This commit is contained in:
printempw 2016-01-22 15:49:05 +08:00
parent 51a874c489
commit 4f6de60a35
3 changed files with 12 additions and 8 deletions

View File

@ -3,7 +3,7 @@
* @Author: printempw
* @Date: 2016-01-16 23:01:33
* @Last Modified by: prpr
* @Last Modified time: 2016-01-22 15:04:59
* @Last Modified time: 2016-01-22 15:47:36
*/
class user {
@ -76,10 +76,12 @@ class user {
$hash = utils::upload($file);
if ($type == "skin") {
// remove the original texture first
utils::remove("./textures/".$this->getTexture('skin'));
if ($this->getTexture('skin') != "")
utils::remove("./textures/".$this->getTexture('skin'));
return utils::update($this->uname, 'skin_hash', $hash);
} else if ($type == "cape") {
utils::remove("./textures/".$this->getTexture('cape'));
if ($this->getTexture('cape') != "")
utils::remove("./textures/".$this->getTexture('cape'));
return utils::update($this->uname, 'cape_hash', $hash);
}
return false;

View File

@ -3,7 +3,7 @@
* @Author: printempw
* @Date: 2016-01-16 23:01:33
* @Last Modified by: prpr
* @Last Modified time: 2016-01-22 15:04:56
* @Last Modified time: 2016-01-22 15:46:20
*/
$dir = dirname(dirname(__FILE__));
require "$dir/config.php";
@ -99,10 +99,12 @@ class utils {
* @return $bool
*/
public static function remove($filename) {
if (!unlink($filename)) {
self::raise(-1, "Uncaught error when deleting $filename");
} else {
return true;
if(file_exists($filename)) {
if (!unlink($filename)) {
self::raise(-1, "Uncaught error when deleting $filename");
} else {
return true;
}
}
}

Binary file not shown.

After

Width:  |  Height:  |  Size: 114 KiB