From 402eec0b3c1e235a87af717d77dd08ad6b894634 Mon Sep 17 00:00:00 2001
From: Pig Fang <g-plane@hotmail.com>
Date: Wed, 4 Sep 2019 23:16:49 +0800
Subject: [PATCH] Simplify syntax

---
 app/Http/Controllers/UserController.php | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git a/app/Http/Controllers/UserController.php b/app/Http/Controllers/UserController.php
index b8c42ace..1e396eb3 100644
--- a/app/Http/Controllers/UserController.php
+++ b/app/Http/Controllers/UserController.php
@@ -40,7 +40,7 @@ class UserController extends Controller
     {
         $user = Auth::user();
 
-        list($from, $to) = explode(',', option('sign_score'));
+        [$from, $to] = explode(',', option('sign_score'));
         $scoreIntro = nl2br(trans('user.score-intro.introduction', [
             'initial_score' => option('user_initial_score'),
             'score-from'    => $from,
@@ -79,14 +79,7 @@ class UserController extends Controller
         ]);
     }
 
-    /**
-     * Calculate percentage of resources used by user.
-     *
-     * @param  int $used
-     * @param  int $rate
-     * @return array
-     */
-    protected function calculatePercentageUsed($used, $rate)
+    protected function calculatePercentageUsed(int $used, int $rate): array
     {
         $user = Auth::user();
         // Initialize default value to avoid division by zero.
@@ -107,18 +100,11 @@ class UserController extends Controller
         return Texture::where('uploader', $user->uid)->select('size')->sum('size');
     }
 
-    /**
-     * Handle user signing.
-     *
-     * @return \Illuminate\Http\JsonResponse
-     */
     public function sign()
     {
         $user = Auth::user();
         if ($this->getSignRemainingTime($user) <= 0) {
-            $scoreLimits = explode(',', option('sign_score'));
-            $acquiredScore = rand($scoreLimits[0], $scoreLimits[1]);
-
+            $acquiredScore = rand(...explode(',', option('sign_score')));
             $user->score += $acquiredScore;
             $user->last_sign_at = Carbon::now()->toDateTimeString();
             $user->save();